Skip to content

Commit 9d0a2a4

Browse files
petrhosektstellar
authored andcommitted
[BOLT][CMake] Use correct output paths and passthrough necessary options
This addresses #62748. Differential Revision: https://reviews.llvm.org/D150752
1 parent 094f771 commit 9d0a2a4

File tree

3 files changed

+11
-5
lines changed

3 files changed

+11
-5
lines changed

bolt/CMakeLists.txt

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,6 +46,10 @@ endif()
4646

4747
if (BOLT_ENABLE_RUNTIME)
4848
message(STATUS "Building BOLT runtime libraries for X86")
49+
set(extra_args "")
50+
if(CMAKE_SYSROOT)
51+
list(APPEND extra_args -DCMAKE_SYSROOT=${CMAKE_SYSROOT})
52+
endif()
4953
ExternalProject_Add(bolt_rt
5054
SOURCE_DIR "${CMAKE_CURRENT_SOURCE_DIR}/runtime"
5155
STAMP_DIR ${CMAKE_CURRENT_BINARY_DIR}/bolt_rt-stamps
@@ -54,8 +58,10 @@ if (BOLT_ENABLE_RUNTIME)
5458
-DCMAKE_CXX_COMPILER=${CMAKE_CXX_COMPILER}
5559
-DCMAKE_BUILD_TYPE=Release
5660
-DCMAKE_MAKE_PROGRAM=${CMAKE_MAKE_PROGRAM}
57-
-DCMAKE_INSTALL_PREFIX=${LLVM_BINARY_DIR}
5861
-DLLVM_LIBDIR_SUFFIX=${LLVM_LIBDIR_SUFFIX}
62+
-DLLVM_LIBRARY_DIR=${LLVM_LIBRARY_DIR}
63+
${extra_args}
64+
INSTALL_COMMAND ""
5965
BUILD_ALWAYS True
6066
)
6167
install(CODE "execute_process\(COMMAND \${CMAKE_COMMAND} -DCMAKE_INSTALL_PREFIX=\${CMAKE_INSTALL_PREFIX} -P ${CMAKE_CURRENT_BINARY_DIR}/bolt_rt-bins/cmake_install.cmake \)"

bolt/runtime/CMakeLists.txt

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,12 +15,12 @@ add_library(bolt_rt_instr STATIC
1515
instr.cpp
1616
${CMAKE_CURRENT_BINARY_DIR}/config.h
1717
)
18-
set_target_properties(bolt_rt_instr PROPERTIES LIBRARY_OUTPUT_DIRECTORY "lib${LLVM_LIBDIR_SUFFIX}")
18+
set_target_properties(bolt_rt_instr PROPERTIES ARCHIVE_OUTPUT_DIRECTORY "${LLVM_LIBRARY_DIR}")
1919
add_library(bolt_rt_hugify STATIC
2020
hugify.cpp
2121
${CMAKE_CURRENT_BINARY_DIR}/config.h
2222
)
23-
set_target_properties(bolt_rt_hugify PROPERTIES LIBRARY_OUTPUT_DIRECTORY "lib${LLVM_LIBDIR_SUFFIX}")
23+
set_target_properties(bolt_rt_hugify PROPERTIES ARCHIVE_OUTPUT_DIRECTORY "${LLVM_LIBRARY_DIR}")
2424

2525
set(BOLT_RT_FLAGS
2626
-ffreestanding
@@ -44,7 +44,7 @@ if (CMAKE_CXX_COMPILER_ID MATCHES ".*Clang.*")
4444
instr.cpp
4545
${CMAKE_CURRENT_BINARY_DIR}/config.h
4646
)
47-
set_target_properties(bolt_rt_instr_osx PROPERTIES LIBRARY_OUTPUT_DIRECTORY "lib${LLVM_LIBDIR_SUFFIX}")
47+
set_target_properties(bolt_rt_instr_osx PROPERTIES ARCHIVE_OUTPUT_DIRECTORY "${LLVM_LIBRARY_DIR}")
4848
target_include_directories(bolt_rt_instr_osx PRIVATE ${CMAKE_CURRENT_BINARY_DIR})
4949
target_compile_options(bolt_rt_instr_osx PRIVATE
5050
-target x86_64-apple-darwin19.6.0

clang/cmake/caches/Fuchsia-stage2.cmake

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -253,7 +253,6 @@ set(LLVM_INSTALL_TOOLCHAIN_ONLY ON CACHE BOOL "")
253253
set(LLVM_TOOLCHAIN_TOOLS
254254
dsymutil
255255
llvm-ar
256-
llvm-bolt
257256
llvm-cov
258257
llvm-cxxfilt
259258
llvm-debuginfod-find
@@ -287,6 +286,7 @@ set(LLVM_TOOLCHAIN_TOOLS
287286
CACHE STRING "")
288287

289288
set(LLVM_DISTRIBUTION_COMPONENTS
289+
bolt
290290
clang
291291
lld
292292
LTO

0 commit comments

Comments
 (0)