Skip to content

Commit 9d24c49

Browse files
[mlir][GPU][NFC] add TODO message for amdgpu-specific pattern relocation
Signed-off-by: Muzammiluddin Syed <[email protected]>
1 parent f8b5f86 commit 9d24c49

File tree

2 files changed

+4
-0
lines changed

2 files changed

+4
-0
lines changed

mlir/lib/Dialect/GPU/Transforms/PromoteShuffleToAMDGPU.cpp

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,8 @@ namespace {
2626

2727
constexpr amdgpu::Chipset kGfx950 = amdgpu::Chipset(9, 5, 0);
2828

29+
// TODO: Move amdgpu specific patterns out of GPU dialect (#165811).
30+
2931
/// Try to promote `gpu.shuffle` to `amdgpu.swizzle_bitmode`, width must be 64
3032
/// and offset must be a constant integer in the range [0, 31].
3133
struct PromoteShuffleToSwizzlePattern

mlir/lib/Dialect/GPU/Transforms/SubgroupReduceLowering.cpp

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -367,6 +367,8 @@ struct VectorSubgroupReduceToShuffles final
367367
bool matchClustered = false;
368368
};
369369

370+
// TODO: Move amdgpu specific patterns out of GPU dialect (#165811).
371+
370372
static FailureOr<Value>
371373
createSubgroupDPPReduction(PatternRewriter &rewriter, gpu::SubgroupReduceOp op,
372374
Value input, gpu::AllReduceOperation mode,

0 commit comments

Comments
 (0)