review comments

Created using spr 1.3.5-bogner

Author: MaskRay

lld/ELF/InputSection.cpp

@@ -1365,14 +1365,14 @@ template <class ELFT> void EhInputSection::split() {
     preprocessRelocs<ELFT>(elfRels.rels);
   else
     preprocessRelocs<ELFT>(elfRels.relas);
+
+  // The loop below expects the relocations to be sorted by offset.
   auto cmp = [](const Relocation &a, const Relocation &b) {
     return a.offset < b.offset;
   };
   if (!llvm::is_sorted(rels, cmp))
     llvm::stable_sort(rels, cmp);
 
-  // getReloc expects the relocations to be sorted by r_offset. See the comment
-  // in scanRelocs.
   ArrayRef<uint8_t> d = content();
   const char *msg = nullptr;
   unsigned relI = 0;

lld/ELF/MarkLive.cpp

@@ -155,7 +155,7 @@ void MarkLive<ELFT, TrackWhyLive>::resolveReloc(InputSectionBase &sec,
     // associated text section is live, the LSDA will be retained due to section
     // group/SHF_LINK_ORDER rules (b) if the associated text section should be
     // discarded, marking the LSDA will unnecessarily retain the text section.
-    if (!(std::is_same_v<RelTy, Relocation> && fromFDE &&
+    if (!(fromFDE && std::is_same_v<RelTy, Relocation> &&
           ((relSec->flags & (SHF_EXECINSTR | SHF_LINK_ORDER)) ||
            relSec->nextInSectionGroup))) {
       Symbol *canonicalSym = d;