Address code review comments

Author: AmrDeveloper

clang/include/clang/CIR/Dialect/IR/CIRAttrs.td

@@ -288,8 +288,15 @@ def ConstComplexAttr : CIR_Attr<"ConstComplex", "const_complex",
     type. The `real` parameter gives the real part of the complex number and the
     `imag` parameter gives the imaginary part of the complex number.
 
-    The `real` and `imag` parameter must be either an IntAttr or an FPAttr that
-    contains values of the same CIR type.
+    The `real` and `imag` parameters must both reference the same type and must
+    be either IntAttr or FPAttr.
+
+    ```mlir
+    %ci = #cir.const_complex<#cir.int<1> : !s32i, #cir.int<2> : !s32i>
+        : !cir.complex<!s32i>
+    %cf = #cir.const_complex<#cir.fp<1.000000e+00> : !cir.float,
+        #cir.fp<2.000000e+00> : !cir.float> : !cir.complex<!cir.float>
+    ```
   }];
 
   let parameters = (ins

clang/include/clang/CIR/Dialect/IR/CIRTypes.td

@@ -179,6 +179,11 @@ def CIR_ComplexType : CIR_Type<"Complex", "complex",
     The parameter `elementType` gives the type of the real and imaginary part of
     the complex number. `elementType` must be either a CIR integer type or a CIR
     floating-point type.
+
+    ```mlir
+    !cir.complex<!s32i>
+    !cir.complex<!cir.float>
+    ```
   }];
 
   let parameters = (ins CIR_AnyIntOrFloatType:$elementType);

clang/lib/CIR/CodeGen/CIRGenExprConstant.cpp

@@ -592,6 +592,8 @@ mlir::Attribute ConstantEmitter::tryEmitPrivate(const APValue &value,
           builder.getAttr<cir::IntAttr>(complexElemTy, imag));
     }
 
+    assert(isa<cir::CIRFPTypeInterface>(complexElemTy) &&
+           "expected floating-point type");
     llvm::APFloat real = value.getComplexFloatReal();
     llvm::APFloat imag = value.getComplexFloatImag();
     return builder.getAttr<cir::ConstComplexAttr>(

clang/lib/CIR/Dialect/IR/CIRDialect.cpp

@@ -234,7 +234,7 @@ static LogicalResult checkConstantTypes(mlir::Operation *op, mlir::Type opType,
             opType))
       return success();
     return op->emitOpError(
-        "zero expects struct, array, vector or complex type");
+        "zero expects struct, array, vector, or complex type");
   }
 
   if (mlir::isa<cir::BoolAttr>(attrType)) {

clang/test/CIR/IR/invalid-const-complex-wrong-imaginary-type.cir

@@ -0,0 +1,11 @@
+// RUN: cir-opt %s -verify-diagnostics -split-input-file
+
+!s32i = !cir.int<s, 32>
+!s64i = !cir.int<s, 64>
+
+module {
+
+// expected-error @below {{type of the imaginary part does not match the complex type}}
+cir.global external @ci2 = #cir.const_complex<#cir.int<1> : !s32i, #cir.int<2> : !s64i> : !cir.complex<!s32i>
+
+}

clang/test/CIR/IR/invalid-const-complex-wrong-real-type.cir

@@ -0,0 +1,11 @@
+// RUN: cir-opt %s -verify-diagnostics -split-input-file
+
+!s32i = !cir.int<s, 32>
+!s64i = !cir.int<s, 64>
+
+module {
+
+// expected-error @below {{type of the real part does not match the complex type}}
+cir.global external @ci2 = #cir.const_complex<#cir.int<1> : !s64i, #cir.int<2> : !s32i> : !cir.complex<!s32i>
+
+}