Apply suggestions from code review

Co-authored-by: Matt Arsenault <[email protected]>

Author: frederik-h

llvm/test/CodeGen/AMDGPU/sdwa-peephole-cndmask-vop3-wave32.mir

@@ -150,8 +150,6 @@ body:             |
 ---
 name: missing-carry-def
 tracksRegLiveness: true
-registers:
-  - { id: 0, class: sreg_32_xm0_xexec }
 body:             |
   bb.0:
     liveins: $vgpr0
@@ -165,7 +163,7 @@ body:             |
     ; CHECK-NEXT: $vgpr0 = COPY [[V_CNDMASK_B32_e64_]]
     ; CHECK-NEXT: SI_RETURN implicit $vgpr0
     %1:vgpr_32 = IMPLICIT_DEF
-    %2:vgpr_32 = V_LSHRREV_B32_e64 16, undef %1, implicit $exec
+    %2:vgpr_32 = V_LSHRREV_B32_e64 16, undef %1:sreg_32_xm0_xexec, implicit $exec
     %3:vgpr_32 = V_CNDMASK_B32_e64 0, 0, 0, %2, undef %0, implicit $exec
     $vgpr0 = COPY %3
     SI_RETURN implicit $vgpr0

llvm/test/CodeGen/AMDGPU/sdwa-peephole-cndmask-vop3-wave64.mir

@@ -50,9 +50,9 @@ body:             |
     ; CHECK-NEXT: SI_RETURN implicit $vgpr0
     %0:sreg_64_xexec = IMPLICIT_DEF
     %1:vgpr_32 = IMPLICIT_DEF
-    %2:vgpr_32 = V_PK_MAX_F16 8, undef %1, 8, undef %1, 0, 0, 0, 0, 0, implicit $mode, implicit $exec
+    %2:vgpr_32 = V_PK_MAX_F16 8, %1, 8, %1, 0, 0, 0, 0, 0, implicit $mode, implicit $exec
     %3:vgpr_32 = V_LSHRREV_B32_e64 16, undef %2, implicit $exec
-    %4:vgpr_32 = V_CNDMASK_B32_e64 0, 0, 0, %3, killed undef %0, implicit $exec
+    %4:vgpr_32 = V_CNDMASK_B32_e64 0, 0, 0, %3, killed %0, implicit $exec
     $vgpr0 = COPY %4
     SI_RETURN implicit $vgpr0
 ...
@@ -82,7 +82,7 @@ body:             |
     %1:vgpr_32 = IMPLICIT_DEF
     %2:vgpr_32 = V_PK_MAX_F16 8, undef %1, 8, undef %1, 0, 0, 0, 0, 0, implicit $mode, implicit $exec
     %3:vgpr_32 = V_LSHRREV_B32_e64 16, %2, implicit $exec
-    %4:vgpr_32 = V_CNDMASK_B32_e64 0, 0, 0, %3, killed undef %0, implicit $exec
+    %4:vgpr_32 = V_CNDMASK_B32_e64 0, 0, 0, %3, killed %0, implicit $exec
     $vgpr0 = COPY %4
     $vgpr1 = COPY %0
     SI_RETURN implicit $vgpr0
@@ -110,9 +110,9 @@ body:             |
     ; CHECK-NEXT: SI_RETURN implicit $vgpr0
     %0:vgpr_32 = IMPLICIT_DEF
     %2:vgpr_32 = IMPLICIT_DEF
-    %3:sreg_64_xexec = V_CMP_EQ_U32_e64 undef %0, 1, implicit $exec
-    %5:vgpr_32 = V_LSHRREV_B32_e64 16, undef %2, implicit $exec
-    V_CMP_EQ_U32_e32 1, undef %2, implicit-def $vcc, implicit $exec
+    %3:sreg_64_xexec = V_CMP_EQ_U32_e64 %0, 1, implicit $exec
+    %5:vgpr_32 = V_LSHRREV_B32_e64 16, %2, implicit $exec
+    V_CMP_EQ_U32_e32 1, %2, implicit-def $vcc, implicit $exec
     %6:vgpr_32 = V_CNDMASK_B32_e64 0, 0, 0, %5, %3, implicit $exec
     %7:vgpr_32 = V_CNDMASK_B32_e32 killed %5, killed %5, implicit $vcc, implicit $exec
     $vgpr0 = COPY %6
@@ -165,7 +165,7 @@ body:             |
     ; CHECK-NEXT: $vgpr0 = COPY [[V_CNDMASK_B32_e64_]]
     ; CHECK-NEXT: SI_RETURN implicit $vgpr0
     %1:vgpr_32 = IMPLICIT_DEF
-    %2:vgpr_32 = V_LSHRREV_B32_e64 16, undef %1, implicit $exec
+    %2:vgpr_32 = V_LSHRREV_B32_e64 16, %1, implicit $exec
     %3:vgpr_32 = V_CNDMASK_B32_e64 0, 0, 0, %2, undef %0, implicit $exec
     $vgpr0 = COPY %3
     SI_RETURN implicit $vgpr0