Hoist variable. NFC

Author: amd-eochoalo

mlir/lib/Conversion/AMDGPUToROCDL/AMDGPUToROCDL.cpp

@@ -1728,68 +1728,34 @@ LogicalResult ScaledExtPacked816OpLowering::matchAndRewrite(
   //
   // largeT = [F16, Bf16, F32]
   // CvtPkScalePk8${largeT}${smallT}
+  Value castedSource =
+      LLVM::BitcastOp::create(rewriter, loc, packedType, source);
 
   if (isa<Float4E2M1FNType>(srcElemType) and destElemType.isF16()) {
-    // CvtPkScalePk8F16Fp4Op
-    // i32
-    Value castedSource =
-        LLVM::BitcastOp::create(rewriter, loc, packedType, source);
     rewriter.replaceOpWithNewOp<ROCDL::CvtPkScalePk8F16Fp4Op>(
         op, op.getResult().getType(), castedSource, castedScale, scaleSel);
   } else if (isa<Float8E4M3FNType>(srcElemType) and destElemType.isF16()) {
-    // CvtPkScalePk8F16Fp8Op
-    // vector<8xf8E4M3FN>
-    Value castedSource =
-        LLVM::BitcastOp::create(rewriter, loc, packedType, source);
     rewriter.replaceOpWithNewOp<ROCDL::CvtPkScalePk8F16Fp8Op>(
         op, op.getResult().getType(), castedSource, castedScale, scaleSel);
   } else if (isa<Float8E5M2Type>(srcElemType) and destElemType.isF16()) {
-    // CvtPkScalePk8F16Bf8Op
-    // vector<8xf8E5M2>
-    Value castedSource =
-        LLVM::BitcastOp::create(rewriter, loc, packedType, source);
     rewriter.replaceOpWithNewOp<ROCDL::CvtPkScalePk8F16Bf8Op>(
         op, op.getResult().getType(), castedSource, castedScale, scaleSel);
   } else if (isa<Float4E2M1FNType>(srcElemType) and destElemType.isBF16()) {
-    // CvtPkScalePk8Bf16Fp4Op
-    // i32
-    Value castedSource =
-        LLVM::BitcastOp::create(rewriter, loc, packedType, source);
     rewriter.replaceOpWithNewOp<ROCDL::CvtPkScalePk8Bf16Fp4Op>(
         op, op.getResult().getType(), castedSource, castedScale, scaleSel);
   } else if (isa<Float8E4M3FNType>(srcElemType) and destElemType.isBF16()) {
-    // CvtPkScalePk8Bf16Fp8Op
-    // vector<8xf8E4M3FN>
-    Value castedSource =
-        LLVM::BitcastOp::create(rewriter, loc, packedType, source);
     rewriter.replaceOpWithNewOp<ROCDL::CvtPkScalePk8Bf16Fp8Op>(
         op, op.getResult().getType(), castedSource, castedScale, scaleSel);
   } else if (isa<Float8E5M2Type>(srcElemType) and destElemType.isBF16()) {
-    // CvtPkScalePk8Bf16Bf8Op
-    // vector<8xf8E5M2>
-    Value castedSource =
-        LLVM::BitcastOp::create(rewriter, loc, packedType, source);
     rewriter.replaceOpWithNewOp<ROCDL::CvtPkScalePk8Bf16Bf8Op>(
         op, op.getResult().getType(), castedSource, castedScale, scaleSel);
   } else if (isa<Float4E2M1FNType>(srcElemType) and destElemType.isF32()) {
-    // CvtPkScalePk8F32Fp4Op
-    // i32
-    Value castedSource =
-        LLVM::BitcastOp::create(rewriter, loc, packedType, source);
     rewriter.replaceOpWithNewOp<ROCDL::CvtPkScalePk8F32Fp4Op>(
         op, op.getResult().getType(), castedSource, castedScale, scaleSel);
   } else if (isa<Float8E4M3FNType>(srcElemType) and destElemType.isF32()) {
-    // CvtPkScalePk8F32Fp8Op
-    // vector<8xf8E4M3FN>
-    Value castedSource =
-        LLVM::BitcastOp::create(rewriter, loc, packedType, source);
     rewriter.replaceOpWithNewOp<ROCDL::CvtPkScalePk8F32Fp8Op>(
         op, op.getResult().getType(), castedSource, castedScale, scaleSel);
   } else if (isa<Float8E5M2Type>(srcElemType) and destElemType.isF32()) {
-    // CvtPkScalePk8F32Bf8Op
-    // vector<8xf8E5M2>
-    Value castedSource =
-        LLVM::BitcastOp::create(rewriter, loc, packedType, source);
     rewriter.replaceOpWithNewOp<ROCDL::CvtPkScalePk8F32Bf8Op>(
         op, op.getResult().getType(), castedSource, castedScale, scaleSel);
   }
@@ -1801,39 +1767,21 @@ LogicalResult ScaledExtPacked816OpLowering::matchAndRewrite(
 
   // CvtPkScalePk16${largeT}${smallT}
   else if (isa<Float6E2M3FNType>(srcElemType) and destElemType.isF16()) {
-    // CvtPkScale16F16Fp6Op
-    Value castedSource =
-        LLVM::BitcastOp::create(rewriter, loc, packedType, source);
     rewriter.replaceOpWithNewOp<ROCDL::CvtPkScalePk16F16Fp6Op>(
         op, op.getResult().getType(), castedSource, castedScale, scaleSel);
   } else if (isa<Float6E3M2FNType>(srcElemType) and destElemType.isF16()) {
-    // CvtPkScale16F16Bf6Op
-    Value castedSource =
-        LLVM::BitcastOp::create(rewriter, loc, packedType, source);
     rewriter.replaceOpWithNewOp<ROCDL::CvtPkScalePk16F16Bf6Op>(
         op, op.getResult().getType(), castedSource, castedScale, scaleSel);
   } else if (isa<Float6E2M3FNType>(srcElemType) and destElemType.isBF16()) {
-    // CvtPkScale16Bf16Fp6Op
-    Value castedSource =
-        LLVM::BitcastOp::create(rewriter, loc, packedType, source);
     rewriter.replaceOpWithNewOp<ROCDL::CvtPkScalePk16Bf16Fp6Op>(
         op, op.getResult().getType(), castedSource, castedScale, scaleSel);
   } else if (isa<Float6E3M2FNType>(srcElemType) and destElemType.isBF16()) {
-    // CvtPkScale16Bf16Bf6Op
-    Value castedSource =
-        LLVM::BitcastOp::create(rewriter, loc, packedType, source);
     rewriter.replaceOpWithNewOp<ROCDL::CvtPkScalePk16Bf16Bf6Op>(
         op, op.getResult().getType(), castedSource, castedScale, scaleSel);
   } else if (isa<Float6E2M3FNType>(srcElemType) and destElemType.isF32()) {
-    // CvtPkScale16F32Fp6Op
-    Value castedSource =
-        LLVM::BitcastOp::create(rewriter, loc, packedType, source);
     rewriter.replaceOpWithNewOp<ROCDL::CvtPkScalePk16F32Fp6Op>(
         op, op.getResult().getType(), castedSource, castedScale, scaleSel);
   } else if (isa<Float6E3M2FNType>(srcElemType) and destElemType.isF32()) {
-    // CvtPkScale16F32Bf6Op
-    Value castedSource =
-        LLVM::BitcastOp::create(rewriter, loc, packedType, source);
     rewriter.replaceOpWithNewOp<ROCDL::CvtPkScalePk16F32Bf6Op>(
         op, op.getResult().getType(), castedSource, castedScale, scaleSel);
   } else {