Skip to content

Commit 9e579b9

Browse files
committed
fix: pr comment, feat: new test for SmallDenseSet.
1 parent 489fd2c commit 9e579b9

File tree

3 files changed

+9
-1
lines changed

3 files changed

+9
-1
lines changed

llvm/include/llvm/ADT/DenseMap.h

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -303,6 +303,7 @@ class DenseMapBase : public DebugEpochBase {
303303
insert(*I);
304304
}
305305

306+
/// Inserts range of 'std::pair<KeyT, ValueT>' values into the map.
306307
template <typename Range> void insert_range(Range &&R) {
307308
insert(adl_begin(R), adl_end(R));
308309
}

llvm/unittests/ADT/DenseMapTest.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -385,7 +385,7 @@ TEST(DenseMapCustomTest, InsertRange) {
385385
std::pair<int, int> InputVals[3] = {{0, 0}, {0, 1}, {1, 2}};
386386
M.insert_range(InputVals);
387387

388-
EXPECT_EQ(2u, M.size());
388+
EXPECT_EQ(M.size(), 2u);
389389
EXPECT_THAT(M, testing::UnorderedElementsAre(testing::Pair(0, 0),
390390
testing::Pair(1, 2)));
391391
}

llvm/unittests/ADT/DenseSetTest.cpp

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -58,6 +58,13 @@ TEST(DenseSetTest, InsertRange) {
5858
EXPECT_THAT(set, ::testing::UnorderedElementsAre(1, 2, 3));
5959
}
6060

61+
TEST(SmallDenseSetTest, InsertRange) {
62+
llvm::SmallDenseSet<unsigned> set;
63+
constexpr unsigned Args[] = {9, 7, 8};
64+
set.insert_range(Args);
65+
EXPECT_THAT(set, ::testing::UnorderedElementsAre(7, 8, 9));
66+
}
67+
6168
struct TestDenseSetInfo {
6269
static inline unsigned getEmptyKey() { return ~0; }
6370
static inline unsigned getTombstoneKey() { return ~0U - 1; }

0 commit comments

Comments
 (0)