Skip to content

Commit 9e6cf29

Browse files
committed
address comments
1 parent 68f95f0 commit 9e6cf29

File tree

2 files changed

+2
-6
lines changed

2 files changed

+2
-6
lines changed

mlir/include/mlir/Dialect/XeGPU/IR/XeGPUDialect.td

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -38,8 +38,6 @@ def XeGPU_Dialect : Dialect {
3838
let useDefaultAttributePrinterParser = true;
3939

4040
let extraClassDeclaration = [{
41-
static constexpr const char *operandLayoutNamePrefix = "layout_operand_";
42-
static constexpr const char *resultLayoutNamePrefix = "layout_result_";
4341
/// Checks if the given shape can be evenly distributed based on the layout
4442
/// and data factors provided by the LayoutAttr.
4543
static bool isEvenlyDistributable(llvm::ArrayRef<int64_t> shape, xegpu::LayoutAttr attr);

mlir/lib/Dialect/XeGPU/Transforms/XeGPUUnroll.cpp

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -446,10 +446,8 @@ struct UnrollDpasOp : public UnrollPattern<xegpu::DpasOp> {
446446
if (c)
447447
cVals = packWrapper(c, cBlockSize);
448448

449-
// Vals are empty due to invalid blocking size, or with size 1 due to
450-
// the original shape is the same with the blocking size. The op will
451-
// be skipped if every operand got an invalid blocking size or the
452-
// original shape is the same with the blocking size.
449+
// skip the operation if every operand has an invalid blocking size (empty)
450+
// or if the original shape matches the blocking size (size == 1).
453451
if (aVals.size() <= 1 && bVals.size() <= 1 && cVals.size() <= 1)
454452
return failure();
455453

0 commit comments

Comments
 (0)