Skip to content

Commit 9e81b46

Browse files
committed
fix CI failure, revert changes to warn_impcast_matrix_scalar. the VectorConversion group is more invasive than expected
1 parent 2b0167a commit 9e81b46

File tree

3 files changed

+4
-2
lines changed

3 files changed

+4
-2
lines changed

clang/include/clang/Basic/DiagnosticGroups.td

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1337,7 +1337,7 @@ def : DiagGroup<"int-conversions",
13371337
def : DiagGroup<"vector-conversions",
13381338
[VectorConversion]>; // -Wvector-conversions = -Wvector-conversion
13391339
def : DiagGroup<"matrix-conversions",
1340-
[MatrixConversion]>; // -Wvector-conversions = -Wmatrix-conversion
1340+
[MatrixConversion]>; // -Wmatrix-conversions = -Wmatrix-conversion
13411341
def : DiagGroup<"unused-local-typedefs", [UnusedLocalTypedef]>;
13421342
// -Wunused-local-typedefs = -Wunused-local-typedef
13431343

clang/include/clang/Basic/DiagnosticSemaKinds.td

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4343,7 +4343,7 @@ def warn_impcast_matrix_scalar : Warning<
43434343
InGroup<MatrixConversion>, DefaultIgnore;
43444344
def warn_impcast_vector_scalar : Warning<
43454345
"implicit conversion turns vector to scalar: %0 to %1">,
4346-
InGroup<VectorConversion>, DefaultIgnore;
4346+
InGroup<Conversion>, DefaultIgnore;
43474347
def warn_impcast_complex_scalar : Warning<
43484348
"implicit conversion discards imaginary component: %0 to %1">,
43494349
InGroup<Conversion>, DefaultIgnore;

clang/test/Driver/autocomplete.c

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -117,6 +117,8 @@
117117
// WARNING-NEXT: -Wmany-braces-around-scalar-init
118118
// WARNING-NEXT: -Wmath-errno-enabled-with-veclib
119119
// WARNING-NEXT: -Wmathematical-notation-identifier-extension
120+
// WARNING-NEXT: -Wmatrix-conversion
121+
// WARNING-NEXT: -Wmatrix-conversions
120122
// WARNING-NEXT: -Wmax-tokens
121123
// WARNING-NEXT: -Wmax-unsigned-zero
122124
// RUN: %clang --autocomplete=-Wno-invalid-pp- | FileCheck %s -check-prefix=NOWARNING

0 commit comments

Comments
 (0)