Add review changes

Author: da-viper

lldb/bindings/lua/lua-typemaps.swig

@@ -121,10 +121,21 @@ LLDB_NUMBER_TYPEMAP(enum SWIGTYPE);
   $1 = (char *)malloc($2);
 }
 
-// Remove the default type check for this match.
-// because if the match function has an overload and a typemap,
-// it will typecheck against the original function instead of the
-// typemap.
+// Disable default type checking for this method to avoid SWIG dispatch issues.
+// 
+// Problem: SBThread::GetStopDescription has two overloads:
+//   1. GetStopDescription(char* dst_or_null, size_t dst_len) 
+//   2. GetStopDescription(lldb::SBStream& stream)
+//
+// SWIG generates a dispatch function to select the correct overload based on argument types.
+// see https://www.swig.org/Doc4.0/SWIGDocumentation.html#Typemaps_overloading.
+// However, this dispatcher doesn't consider typemaps that transform function signatures.
+//
+// In lua, our typemap converts GetStopDescription(char*, size_t) to GetStopDescription(int).
+// The dispatcher still checks against the original (char*, size_t) signature instead of 
+// the transformed (int) signature, causing type matching to fail.
+// This only affects SBThread::GetStopDescription since the type check also matches 
+// the argument name, which is unique to this function.
 %typemap(typecheck, precedence=SWIG_TYPECHECK_POINTER) (char *dst_or_null, size_t dst_len) ""
 
 %typemap(argout) (char *dst_or_null, size_t dst_len) {

lldb/bindings/python/python-typemaps.swig

@@ -225,10 +225,21 @@ AND call SWIG_fail at the same time, because it will result in a double free.
   $1 = (char *)malloc($2);
 }
 
-// Remove the default type check for this match.
-// because if the match function has an overload and a typemap,
-// it will typecheck against the original function instead of the
-// typemap.
+// Disable default type checking for this method to avoid SWIG dispatch issues.
+// 
+// Problem: SBThread::GetStopDescription has two overloads:
+//   1. GetStopDescription(char* dst_or_null, size_t dst_len) 
+//   2. GetStopDescription(lldb::SBStream& stream)
+//
+// SWIG generates a dispatch function to select the correct overload based on argument types.
+// see https://www.swig.org/Doc4.0/SWIGDocumentation.html#Typemaps_overloading.
+// However, this dispatcher doesn't consider typemaps that transform function signatures.
+//
+// In Python, our typemap converts GetStopDescription(char*, size_t) to GetStopDescription(int).
+// The dispatcher still checks against the original (char*, size_t) signature instead of 
+// the transformed (int) signature, causing type matching to fail.
+// This only affects SBThread::GetStopDescription since the type check also matches 
+// the argument name, which is unique to this function.
 %typemap(typecheck, precedence=SWIG_TYPECHECK_POINTER) (char *dst_or_null, size_t dst_len) ""
 
 %typemap(argout) (char *dst_or_null, size_t dst_len) {

lldb/tools/lldb-rpc-gen/RPCCommon.cpp

@@ -118,7 +118,6 @@ static constexpr llvm::StringRef MethodsWithPointerPlusLen[] = {
     "_ZN4lldb8SBTarget15GetInstructionsEyPKvm",
     "_ZN4lldb8SBTarget25GetInstructionsWithFlavorEyPKcPKvm",
     "_ZN4lldb8SBThread18GetStopDescriptionEPcm",
-    "_ZNK4lldb8SBThread18GetStopDescriptionERNS_8SBStreamE",
     // The below mangled names are used for dummy methods in shell tests
     // that test the emitters' output. If you're adding any new mangled names
     // from the actual SB API to this list please add them above.