Implement feedback from Dave

Author: Jlalond

lldb/bindings/interface/SBSaveCoreOptionsDocstrings.i

@@ -64,8 +64,8 @@ Note that currently ELF Core files are not supported."
 ) lldb::SBSaveCoreOptions::GetThreadsToSave;
 
 %feature("docstring", "
-    Get the current total number of bytes the core is expectd to have, excluding the overhead of the core file format.
-    Requires both a Process and a Style to be specified."
+    Get the current total number of bytes the core is expected to have, excluding the overhead of the core file format.
+    Requires both a Process and a Style to be specified. An error will be returned if the provided options would result in no data being saved."
 ) lldb::SBSaveCoreOptions::GetCurrentSizeInBytes;
 
 %feature("docstring", "

lldb/test/API/python_api/sbsavecoreoptions/TestSBSaveCoreOptions.py

@@ -105,23 +105,62 @@ def test_removing_and_adding_insertion_order(self):
         self.assertEqual(thread_collection.GetSize(), 3)
         self.assertIn(middle_thread, thread_collection)
 
-    def test_get_total_in_bytes(self):
+    def test_get_current_size_in_bytes(self):
         """
-        Tests that get total in bytes properly returns an error without a process,
+        Tests that ensures GetCurrentSizeInBytes properly returns an error without a process,
         and the readable regions with a process.
         """
 
         options = lldb.SBSaveCoreOptions()
         options.SetStyle(lldb.eSaveCoreCustomOnly)
         process = self.get_basic_process()
         memory_range = lldb.SBMemoryRegionInfo()
-        process.GetMemoryRegionInfo(0x7FFF12A84030, memory_range)
+        
+        # Add the memory range of 0x1000-0x1100
+        process.GetMemoryRegionInfo(0x1000, memory_range)
         options.AddMemoryRegionToSave(memory_range)
+
+        # Check that we fail when we have no process set
+        # even though we added a memory region.
         error = lldb.SBError()
         total = options.GetCurrentSizeInBytes(error)
         self.assertTrue(error.Fail(), error.GetCString())
+
+        # Check that we don't get an error now that we've added a process
         options.SetProcess(process)
         total = options.GetCurrentSizeInBytes(error)
         self.assertTrue(error.Success(), error.GetCString())
+
+        # Validate the size returned is the same size as the single region we added.
         expected_size = memory_range.GetRegionEnd() - memory_range.GetRegionBase()
         self.assertEqual(total, expected_size)
+
+    def test_get_total_in_bytes_missing_requirements(self):
+        """
+        Tests the matrix of error responses that GetCurrentSizeInBytes
+        """
+
+        options = lldb.SBSaveCoreOptions()
+
+        # No process, no style returns an error.
+        error = lldb.SBError()
+        total = options.GetCurrentSizeInBytes(error)
+        self.assertTrue(error.Fail(), error.GetCString())
+
+        # No process returns an error
+        options.SetStyle(lldb.eSaveCoreCustomOnly)
+        total = options.GetCurrentSizeInBytes(error)
+        self.assertTrue(error.Fail(), error.GetCString())
+
+        options.Clear()
+
+        # No style returns an error
+        process = self.get_basic_process()
+        options.SetProcess(process)
+        total = options.GetCurrentSizeInBytes(error)
+        self.assertTrue(error.Fail(), error.GetCString())
+
+        # Options that result in no valid data returns an error.
+        options.SetStyle(lldb.eSaveCoreCustomOnly)
+        total = options.GetCurrentSizeInBytes(error)
+        self.assertTrue(error.Fail(), error.GetCString())

lldb/test/API/python_api/sbsavecoreoptions/basic_minidump.yaml

@@ -36,6 +36,9 @@ Streams:
           Content:               'BAADBEEF'
   - Type:            Memory64List
     Memory Ranges:
-      - Start of Memory Range: 0x7FFF12A84030
-        Data Size:       0x2FD0
+      - Start of Memory Range: 0x1000
+        Data Size:       0x100
+        Content :        ''
+      - Start of Memory Range: 0x2000
+        Data Size:       0x200
         Content :        ''