remove accidental commit and add negative test

Author: akuhlens

flang-rt/lib/runtime/io-stmt.cpp

@@ -1109,7 +1109,7 @@ template <Direction DIR>
 bool ChildListIoStatementState<DIR>::AdvanceRecord(int n) {
 #if !defined(RT_DEVICE_AVOID_RECURSION)
   // Allow child NAMELIST input to advance
-  if (DIR == Direction::Input) {
+  if (DIR == Direction::Input && this->mutableModes().inNamelist) {
     return this->child().parent().AdvanceRecord(n);
   } else {
     return false;

flang/test/Semantics/intrinsics03.f90

@@ -123,3 +123,12 @@ subroutine s4(ix)
   call s4(index3)
   call s4(index4) ! ok
 end
+
+subroutine ichar_tests()
+  integer, parameter :: a1 = ichar('B')
+  !Without -Wportability, the warning isn't emitted and the parameter is constant.
+  integer, parameter :: a2 = ichar('B ')
+  !ERROR: Character in intrinsic function ichar must have length one
+  !ERROR: Must be a constant value
+  integer, parameter :: a3 = ichar('')
+end subroutine

flang/test/Semantics/intrinsics04.f90

@@ -27,7 +27,7 @@ subroutine s(o,a,p)
 subroutine ichar_tests()
   integer, parameter :: a1 = ichar('B')
   !WARNING: Character in intrinsic function ichar should have length one [-Wportability]
-  integer, parameter :: a = ichar('B ')
+  integer, parameter :: a2 = ichar('B ')
   !ERROR: Character in intrinsic function ichar must have length one
   !ERROR: Must be a constant value
   integer, parameter :: a3 = ichar('')