Skip to content

Commit a01f12d

Browse files
committed
Eagerly return std::make_pair, per @delcypher's feedback
1 parent fb9d38e commit a01f12d

File tree

1 file changed

+7
-17
lines changed

1 file changed

+7
-17
lines changed

clang/lib/CodeGen/CGClass.cpp

Lines changed: 7 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -2783,33 +2783,23 @@ void CodeGenFunction::EmitTypeMetadataCodeForVCall(const CXXRecordDecl *RD,
27832783
/// llvm::SanitizerStatKind.
27842784
static std::pair<SanitizerKind::SanitizerOrdinal, llvm::SanitizerStatKind>
27852785
SanitizerInfoFromCFICheckKind(CodeGenFunction::CFITypeCheckKind TCK) {
2786-
SanitizerKind::SanitizerOrdinal M;
2787-
llvm::SanitizerStatKind SSK;
2788-
27892786
switch (TCK) {
27902787
case CodeGenFunction::CFITCK_VCall:
2791-
M = SanitizerKind::SO_CFIVCall;
2792-
SSK = llvm::SanStat_CFI_VCall;
2793-
break;
2788+
return std::make_pair(SanitizerKind::SO_CFIVCall, llvm::SanStat_CFI_VCall);
27942789
case CodeGenFunction::CFITCK_NVCall:
2795-
M = SanitizerKind::SO_CFINVCall;
2796-
SSK = llvm::SanStat_CFI_NVCall;
2797-
break;
2790+
return std::make_pair(SanitizerKind::SO_CFINVCall,
2791+
llvm::SanStat_CFI_NVCall);
27982792
case CodeGenFunction::CFITCK_DerivedCast:
2799-
M = SanitizerKind::SO_CFIDerivedCast;
2800-
SSK = llvm::SanStat_CFI_DerivedCast;
2801-
break;
2793+
return std::make_pair(SanitizerKind::SO_CFIDerivedCast,
2794+
llvm::SanStat_CFI_DerivedCast);
28022795
case CodeGenFunction::CFITCK_UnrelatedCast:
2803-
M = SanitizerKind::SO_CFIUnrelatedCast;
2804-
SSK = llvm::SanStat_CFI_UnrelatedCast;
2805-
break;
2796+
return std::make_pair(SanitizerKind::SO_CFIUnrelatedCast,
2797+
llvm::SanStat_CFI_UnrelatedCast);
28062798
case CodeGenFunction::CFITCK_ICall:
28072799
case CodeGenFunction::CFITCK_NVMFCall:
28082800
case CodeGenFunction::CFITCK_VMFCall:
28092801
llvm_unreachable("unexpected sanitizer kind");
28102802
}
2811-
2812-
return std::make_pair(M, SSK);
28132803
}
28142804

28152805
void CodeGenFunction::EmitVTablePtrCheckForCall(const CXXRecordDecl *RD,

0 commit comments

Comments
 (0)