Skip to content

Commit a0e87b5

Browse files
committed
Addressed review comments
1 parent 5b842ed commit a0e87b5

File tree

2 files changed

+8
-32
lines changed

2 files changed

+8
-32
lines changed

lldb/source/Plugins/Process/AIX/NativeRegisterContextAIX.cpp

Lines changed: 2 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
//===-- NativeRegisterContextAIX.cpp ------------------------------------===//
1+
//===---- NativeRegisterContextAIX.cpp ------------------------------------===//
22
//
33
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
44
// See https://llvm.org/LICENSE.txt for license information.
@@ -13,7 +13,7 @@ using namespace lldb_private;
1313
using namespace lldb_private::process_aix;
1414

1515
lldb::ByteOrder NativeRegisterContextAIX::GetByteOrder() const {
16-
return m_thread.GetProcess().GetByteOrder();
16+
return lldb::eByteOrderInvalid;
1717
}
1818

1919
Status NativeRegisterContextAIX::ReadRegisterRaw(uint32_t reg_index,
@@ -52,15 +52,3 @@ Status NativeRegisterContextAIX::WriteRegisterSet(void *buf, size_t buf_size,
5252
unsigned int regset) {
5353
return Status("unimplemented");
5454
}
55-
56-
Status NativeRegisterContextAIX::DoReadRegisterValue(uint32_t offset,
57-
const char *reg_name,
58-
uint32_t size,
59-
RegisterValue &value) {
60-
return Status("unimplemented");
61-
}
62-
63-
Status NativeRegisterContextAIX::DoWriteRegisterValue(
64-
uint32_t offset, const char *reg_name, const RegisterValue &value) {
65-
return Status("unimplemented");
66-
}

lldb/source/Plugins/Process/AIX/NativeRegisterContextAIX.h

Lines changed: 6 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -1,20 +1,17 @@
1-
//===-- NativeRegisterContextAIX.h ----------------------------*- C++ -*-===//
1+
//===---- NativeRegisterContextAIX.h ----------------------------*- C++ -*-===//
22
//
33
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
44
// See https://llvm.org/LICENSE.txt for license information.
55
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
66
//
77
//===----------------------------------------------------------------------===//
88

9-
#ifndef lldb_NativeRegisterContextAIX_h
10-
#define lldb_NativeRegisterContextAIX_h
9+
#ifndef LLDB_SOURCE_PLUGINS_PROCESS_AIX_NATIVEREGISTERCONTEXTAIX_H
10+
#define LLDB_SOURCE_PLUGINS_PROCESS_AIX_NATIVEREGISTERCONTEXTAIX_H
1111

1212
#include "Plugins/Process/Utility/NativeRegisterContextRegisterInfo.h"
1313

14-
namespace lldb_private {
15-
namespace process_aix {
16-
17-
class NativeThreadAIX;
14+
namespace lldb_private::process_aix {
1815

1916
class NativeRegisterContextAIX
2017
: public virtual NativeRegisterContextRegisterInfo {
@@ -58,17 +55,8 @@ class NativeRegisterContextAIX
5855
virtual void *GetFPRBuffer() = 0;
5956

6057
virtual size_t GetFPRSize() = 0;
61-
62-
// The Do*** functions are executed on the privileged thread and can perform
63-
// ptrace operations directly.
64-
virtual Status DoReadRegisterValue(uint32_t offset, const char *reg_name,
65-
uint32_t size, RegisterValue &value);
66-
67-
virtual Status DoWriteRegisterValue(uint32_t offset, const char *reg_name,
68-
const RegisterValue &value);
6958
};
7059

71-
} // namespace process_aix
72-
} // namespace lldb_private
60+
} // namespace lldb_private::process_aix
7361

74-
#endif // #ifndef lldb_NativeRegisterContextAIX_h
62+
#endif // #ifndef LLDB_SOURCE_PLUGINS_PROCESS_AIX_NATIVEREGISTERCONTEXTAIX_H

0 commit comments

Comments
 (0)