[Bitcode] Avoid repeated hash lookups (NFC)

kazutakahirata · kazutakahirata · commit a1301cbcbcf7 · 2025-02-25T22:15:20.000-08:00
diff --git a/llvm/lib/Bitcode/Reader/MetadataLoader.cpp b/llvm/lib/Bitcode/Reader/MetadataLoader.cpp
@@ -539,9 +539,10 @@ class MetadataLoader::MetadataLoaderImpl {
       if (!Visited.insert(S).second)
         break;
     }
-    ParentSubprogram[InitialScope] = llvm::dyn_cast_or_null<DISubprogram>(S);
 
-    return ParentSubprogram[InitialScope];
+    auto &PS = ParentSubprogram[InitialScope];
+    PS = llvm::dyn_cast_or_null<DISubprogram>(S);
+    return PS;
   }
 
   /// Move local imports from DICompileUnit's 'imports' field to

Original file line number	Diff line number	Diff line change
`@@ -539,9 +539,10 @@ class MetadataLoader::MetadataLoaderImpl {`
`539`	`539`	`if (!Visited.insert(S).second)`
`540`	`540`	`break;`
`541`	`541`	`}`
`542`		`- ParentSubprogram[InitialScope] = llvm::dyn_cast_or_null<DISubprogram>(S);`
`543`	`542`
`544`		`- return ParentSubprogram[InitialScope];`
	`543`	`+ auto &PS = ParentSubprogram[InitialScope];`
	`544`	`+ PS = llvm::dyn_cast_or_null<DISubprogram>(S);`
	`545`	`+ return PS;`
`545`	`546`	`}`
`546`	`547`
`547`	`548`	`/// Move local imports from DICompileUnit's 'imports' field to`