Skip to content

Commit a1bfa2f

Browse files
authored
AMDGPU: Avoid directly using MCOperandInfo RegClass field (#156641)
This value should not be directly interpreted. Also avoids a function only used for an assert.
1 parent 3576f05 commit a1bfa2f

File tree

1 file changed

+2
-12
lines changed

1 file changed

+2
-12
lines changed

llvm/lib/Target/AMDGPU/GCNDPPCombine.cpp

Lines changed: 2 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -193,16 +193,6 @@ MachineOperand *GCNDPPCombine::getOldOpndValue(MachineOperand &OldOpnd) const {
193193
return &OldOpnd;
194194
}
195195

196-
[[maybe_unused]] static unsigned getOperandSize(MachineInstr &MI, unsigned Idx,
197-
MachineRegisterInfo &MRI) {
198-
int16_t RegClass = MI.getDesc().operands()[Idx].RegClass;
199-
if (RegClass == -1)
200-
return 0;
201-
202-
const TargetRegisterInfo *TRI = MRI.getTargetRegisterInfo();
203-
return TRI->getRegSizeInBits(*TRI->getRegClass(RegClass));
204-
}
205-
206196
MachineInstr *GCNDPPCombine::createDPPInst(MachineInstr &OrigMI,
207197
MachineInstr &MovMI,
208198
RegSubRegPair CombOldVGPR,
@@ -321,8 +311,8 @@ MachineInstr *GCNDPPCombine::createDPPInst(MachineInstr &OrigMI,
321311
// requirements are the same as for src0. We check src0 instead because
322312
// pseudos are shared between subtargets and allow SGPR for src1 on all.
323313
if (!ST->hasDPPSrc1SGPR()) {
324-
assert(getOperandSize(*DPPInst, Src0Idx, *MRI) ==
325-
getOperandSize(*DPPInst, NumOperands, *MRI) &&
314+
assert(TII->getOpSize(*DPPInst, Src0Idx) ==
315+
TII->getOpSize(*DPPInst, NumOperands) &&
326316
"Src0 and Src1 operands should have the same size");
327317
}
328318

0 commit comments

Comments
 (0)