Minor cleanup

mysterymath · mysterymath · commit a1c9f84de743 · 2025-12-01T16:28:52.000-08:00
diff --git a/clang/lib/Sema/SemaDeclAttr.cpp b/clang/lib/Sema/SemaDeclAttr.cpp
@@ -7012,9 +7012,6 @@ static void handleModularFormat(Sema &S, Decl *D, const ParsedAttr &AL) {
     Aspects.push_back(Aspect);
   }
 
-  if (HasDuplicate)
-    return;
-
   // Store aspects sorted.
   llvm::sort(Aspects);
 
@@ -7028,6 +7025,9 @@ static void handleModularFormat(Sema &S, Decl *D, const ParsedAttr &AL) {
     D->dropAttr<ModularFormatAttr>();
   }
 
+  if (HasDuplicate)
+    return;
+
   D->addAttr(::new (S.Context) ModularFormatAttr(
       S.Context, AL, ModularImplFn, ImplName, Aspects.data(), Aspects.size()));
 }

Original file line number	Diff line number	Diff line change
`@@ -7012,9 +7012,6 @@ static void handleModularFormat(Sema &S, Decl *D, const ParsedAttr &AL) {`
`7012`	`7012`	`Aspects.push_back(Aspect);`
`7013`	`7013`	`}`
`7014`	`7014`
`7015`		`- if (HasDuplicate)`
`7016`		`- return;`
`7017`		`-`
`7018`	`7015`	`// Store aspects sorted.`
`7019`	`7016`	`llvm::sort(Aspects);`
`7020`	`7017`
`@@ -7028,6 +7025,9 @@ static void handleModularFormat(Sema &S, Decl *D, const ParsedAttr &AL) {`
`7028`	`7025`	`D->dropAttr<ModularFormatAttr>();`
`7029`	`7026`	`}`
`7030`	`7027`
	`7028`	`+ if (HasDuplicate)`
	`7029`	`+ return;`
	`7030`	`+`
`7031`	`7031`	`D->addAttr(::new (S.Context) ModularFormatAttr(`
`7032`	`7032`	`S.Context, AL, ModularImplFn, ImplName, Aspects.data(), Aspects.size()));`
`7033`	`7033`	`}`