[MLIR][MemRef] Eliminate redundant validation

jiang1997 · jiang1997 · commit a206c538af86 · 2025-09-16T02:40:37.000+08:00
diff --git a/mlir/lib/Dialect/MemRef/IR/MemRefOps.cpp b/mlir/lib/Dialect/MemRef/IR/MemRefOps.cpp
@@ -1549,14 +1549,6 @@ LogicalResult GlobalOp::verify() {
     }
   }
 
-  if (std::optional<uint64_t> alignAttr = getAlignment()) {
-    uint64_t alignment = *alignAttr;
-
-    if (!llvm::isPowerOf2_64(alignment))
-      return emitError() << "alignment attribute value " << alignment
-                         << " is not a power of 2";
-  }
-
   // TODO: verify visibility for declarations.
   return success();
 }

Original file line number	Diff line number	Diff line change
`@@ -1549,14 +1549,6 @@ LogicalResult GlobalOp::verify() {`
`1549`	`1549`	`}`
`1550`	`1550`	`}`
`1551`	`1551`
`1552`		`- if (std::optional<uint64_t> alignAttr = getAlignment()) {`
`1553`		`- uint64_t alignment = *alignAttr;`
`1554`		`-`
`1555`		`- if (!llvm::isPowerOf2_64(alignment))`
`1556`		`- return emitError() << "alignment attribute value " << alignment`
`1557`		`- << " is not a power of 2";`
`1558`		`- }`
`1559`		`-`
`1560`	`1552`	`// TODO: verify visibility for declarations.`
`1561`	`1553`	`return success();`
`1562`	`1554`	`}`