Apply suggestions from code review

Mel-Chen · fhahn · web-flow · commit a23fae9070c8 · 2024-10-29T15:19:16.000+08:00
Correct unwinding attr for MayHaveSideEffect.

Co-authored-by: Florian Hahn &lt;flo@fhahn.com&gt;
diff --git a/llvm/lib/Transforms/Vectorize/VPlan.h b/llvm/lib/Transforms/Vectorize/VPlan.h
@@ -1697,7 +1697,7 @@ class VPWidenIntrinsicRecipe : public VPRecipeWithIRFlags {
     MayReadFromMemory = ME.onlyWritesMemory();
     MayWriteToMemory = ME.onlyReadsMemory();
     MayHaveSideEffects = MayWriteToMemory ||
-                         Attrs.hasFnAttr(Attribute::NoUnwind) ||
+                         !Attrs.hasFnAttr(Attribute::NoUnwind) ||
                          !Attrs.hasFnAttr(Attribute::WillReturn);
   }
 

Original file line number	Diff line number	Diff line change
`@@ -1697,7 +1697,7 @@ class VPWidenIntrinsicRecipe : public VPRecipeWithIRFlags {`
`1697`	`1697`	`MayReadFromMemory = ME.onlyWritesMemory();`
`1698`	`1698`	`MayWriteToMemory = ME.onlyReadsMemory();`
`1699`	`1699`	`MayHaveSideEffects = MayWriteToMemory \|\|`
`1700`		`- Attrs.hasFnAttr(Attribute::NoUnwind) \|\|`
	`1700`	`+ !Attrs.hasFnAttr(Attribute::NoUnwind) \|\|`
`1701`	`1701`	`!Attrs.hasFnAttr(Attribute::WillReturn);`
`1702`	`1702`	`}`
`1703`	`1703`