Fix FP

Author: denzor200

clang-tools-extra/clang-tidy/misc/ShadowedNamespaceFunctionCheck.cpp

@@ -12,6 +12,7 @@
 #include "clang/ASTMatchers/ASTMatchers.h"
 #include "clang/AST/Decl.h"
 #include "clang/AST/DeclCXX.h"
+#include "llvm/ADT/STLExtras.h"
 
 using namespace clang;
 using namespace clang::ast_matchers;
@@ -21,6 +22,18 @@ namespace clang {
 namespace tidy {
 namespace misc {
 
+static bool hasSameParameters(const FunctionDecl *Func1, const FunctionDecl *Func2) {
+  if (Func1->param_size() != Func2->param_size())
+    return false;
+
+  return llvm::all_of_zip(
+      Func1->parameters(), Func2->parameters(),
+      [](const ParmVarDecl *Param1, const ParmVarDecl *Param2) {
+        return Param1->getType().getCanonicalType() ==
+               Param2->getType().getCanonicalType();
+      });
+}
+
 void ShadowedNamespaceFunctionCheck::registerMatchers(MatchFinder *Finder) {
   // Simple matcher for all function definitions
   Finder->addMatcher(
@@ -45,7 +58,7 @@ void ShadowedNamespaceFunctionCheck::check(
 
   // Skip templates, static functions, main, etc.
   if (Func->isTemplated() || Func->isStatic() || 
-      Func->isMain() || Func->isImplicit())
+      Func->isMain() || Func->isImplicit() || Func->isVariadic())
     return;
 
   const std::string FuncName = Func->getNameAsString();
@@ -117,7 +130,7 @@ std::pair<const FunctionDecl *, const NamespaceDecl *> ShadowedNamespaceFunction
           Func->isThisDeclarationADefinition())
         continue;
 
-      if (Func->getNameAsString() == GlobalFuncName) {
+      if (Func->getNameAsString() == GlobalFuncName && !Func->isVariadic() && hasSameParameters(Func, GlobalFunc) && Func->getReturnType().getCanonicalType() == GlobalFunc->getReturnType().getCanonicalType()) {
         return {Func, NS};
       }
     }

clang-tools-extra/docs/clang-tidy/checks/misc/shadowed-namespace-function.rst

@@ -42,4 +42,5 @@ Limitations
 - Does not warn about functions in anonymous namespaces
 - Does not warn about template functions
 - Does not warn about static functions or member functions
+- Does not warn about variadic functions
 - Does not warn about the ``main`` function

clang-tools-extra/test/clang-tidy/checkers/misc/shadowed-namespace-function-good3.cpp

@@ -0,0 +1,9 @@
+// RUN: %check_clang_tidy %s misc-shadowed-namespace-function %t
+
+void f1(int);
+namespace foo {
+  void f0(short);
+  void f1(unsigned);
+}
+void f0(char) {}
+void f1(int) {}

clang-tools-extra/test/clang-tidy/checkers/misc/shadowed-namespace-function-good4.cpp

@@ -0,0 +1,9 @@
+// RUN: %check_clang_tidy %s misc-shadowed-namespace-function %t
+
+int f1();
+namespace foo {
+  char f0();
+  unsigned f1();
+}
+short f0() { return {}; }
+int f1() { return {}; }

clang-tools-extra/test/clang-tidy/checkers/misc/shadowed-namespace-function-using.cpp

@@ -0,0 +1,17 @@
+// RUN: %check_clang_tidy %s misc-shadowed-namespace-function %t
+
+using my_int = int;
+using my_short = short;
+using my_short2 = short;
+
+my_int f1(my_short2);
+namespace foo {
+  int f0(short);
+  int f1(short);
+}
+my_int f0(my_short) {}
+// CHECK-MESSAGES: :[[@LINE-1]]:8: warning: free function 'f0' shadows 'foo::f0' [misc-shadowed-namespace-function]
+// CHECK-FIXES: my_int foo::f0(my_short) {}
+my_int f1(my_short) {}
+// CHECK-MESSAGES: :[[@LINE-1]]:8: warning: free function 'f1' shadows 'foo::f1' [misc-shadowed-namespace-function]
+// CHECK-MESSAGES-NOT: :[[@LINE-2]]:{{.*}}: note: FIX-IT applied suggested code changes

clang-tools-extra/test/clang-tidy/checkers/misc/shadowed-namespace-function-variadic.cpp

@@ -0,0 +1,9 @@
+// RUN: %check_clang_tidy %s misc-shadowed-namespace-function %t
+
+void f1(...);
+namespace foo {
+  void f0(...);
+  void f1(...);
+}
+void f0(...) {}
+void f1(...) {}