add float16 type check

Author: Anagha Rajendra Rao

clang/lib/Sema/SemaSPIRV.cpp

@@ -70,7 +70,8 @@ static bool CheckFloatOrHalfRepresentation(Sema *S, SourceLocation Loc,
       PassedType->isVectorType()
           ? PassedType->castAs<clang::VectorType>()->getElementType()
           : PassedType;
-  if (!BaseType->isHalfType() && !BaseType->isFloat32Type())
+  if (!BaseType->isHalfType() && !BaseType->isFloat16Type() &&
+      !BaseType->isFloat32Type())
     return S->Diag(Loc, diag::err_builtin_invalid_arg_type)
            << ArgOrdinal << /* scalar or vector of */ 5 << /* no int */ 0
            << /* half or float */ 2 << PassedType;
@@ -80,7 +81,8 @@ static bool CheckFloatOrHalfRepresentation(Sema *S, SourceLocation Loc,
 static bool CheckFloatOrHalfScalarRepresentation(Sema *S, SourceLocation Loc,
                                                  int ArgOrdinal,
                                                  clang::QualType PassedType) {
-  if (!PassedType->isHalfType() && !PassedType->isFloat32Type())
+  if (!PassedType->isHalfType() && !PassedType->isFloat16Type() &&
+      !PassedType->isFloat32Type())
     return S->Diag(Loc, diag::err_builtin_invalid_arg_type)
            << ArgOrdinal << /* scalar */ 1 << /* no int */ 0
            << /* half or float */ 2 << PassedType;
@@ -287,7 +289,7 @@ bool SemaSPIRV::CheckSPIRVBuiltinFunctionCall(const TargetInfo &TI,
     if (CheckAllArgTypesAreCorrect(&SemaRef, TheCall,
                                    llvm::ArrayRef(ChecksArr)))
       return true;
-    // Check that first two arguments are vectors of the same type
+    // Check that first two arguments are vectors/scalars of the same type
     QualType Arg0Type = TheCall->getArg(0)->getType();
     if (!SemaRef.getASTContext().hasSameUnqualifiedType(
             Arg0Type, TheCall->getArg(1)->getType()))

clang/test/SemaHLSL/BuiltIns/refract-errors.hlsl

@@ -54,10 +54,6 @@ float1 test_vec1_inputs(float1 p0, float1 p1, float1 p2) {
   // expected-note@hlsl/hlsl_intrinsics.h:* {{candidate template ignored: substitution failure [with L = 1]: no type named 'Type' in 'hlsl::__detail::enable_if<false, float>'}}
 }
 
-float3 test_mixed_datatype_inputs(float3 p0, float3 p1, half p2) {
-  return refract(p0, p1, p2);
-}
-
 typedef float float5 __attribute__((ext_vector_type(5)));
 
 float5 test_vec5_inputs(float5 p0, float5 p1,  float p2) {

clang/test/SemaSPIRV/BuiltIns/refract-errors.c

@@ -27,12 +27,12 @@ float test_int_scalar_inputs(int p0, int p1, int p2) {
 
 float test_float_and_half_inputs(float2 p0, half2 p1, float p2) {
   return __builtin_spirv_refract(p0, p1, p2);
-  //  expected-error@-1 {{2nd argument must be a scalar or vector of 16 or 32 bit floating-point types (was 'half2' (vector of 2 'half' values))}}
+  //  expected-error@-1 {{first two arguments to '__builtin_spirv_refract' must have the same type}}
 }
 
 float test_float_and_half_2_inputs(float2 p0, float2 p1, half p2) {
   return __builtin_spirv_refract(p0, p1, p2);
-  //  expected-error@-1 {{3rd argument must be a scalar 16 or 32 bit floating-point type (was 'half' (aka '_Float16'))}}
+  //  expected-error@-1 {{all arguments to '__builtin_spirv_refract' must be of scalar or vector type with matching scalar element type: 'float2' (vector of 2 'float' values) vs 'half' (aka '_Float16')}}
 }
 
 float2 test_mismatch_vector_size_inputs(float2 p0, float3 p1, float p2) {