[lldb-dap] add review changes

Author: da-viper

lldb/tools/lldb-dap/Handler/ReadMemoryRequestHandler.cpp

@@ -19,8 +19,7 @@ namespace lldb_dap {
 // `supportsReadMemoryRequest` is true
 llvm::Expected<protocol::ReadMemoryResponseBody>
 ReadMemoryRequestHandler::Run(const protocol::ReadMemoryArguments &args) const {
-  const lldb::addr_t raw_address =
-      args.memoryReference + args.offset.value_or(0);
+  const lldb::addr_t raw_address = args.memoryReference + args.offset;
 
   lldb::SBProcess process = dap.target.GetProcess();
   if (!lldb::SBDebugger::StateIsStoppedState(process.GetState()))

lldb/tools/lldb-dap/Protocol/ProtocolRequests.h

@@ -846,7 +846,7 @@ struct ReadMemoryArguments {
 
   /// Offset (in bytes) to be applied to the reference location before reading
   /// data. Can be negative.
-  std::optional<int64_t> offset;
+  int64_t offset = 0;
 
   /// Number of bytes to read at the specified location and offset.
   uint64_t count;

lldb/unittests/DAP/ProtocolTypesTest.cpp

@@ -770,7 +770,7 @@ TEST(ProtocolTypesTest, ReadMemoryArguments) {
   ReadMemoryArguments args;
   args.count = 20;
   args.memoryReference = 43962;
-  args.offset = std::nullopt;
+  args.offset = 0;
 
   llvm::Expected<ReadMemoryArguments> expected =
       parse<ReadMemoryArguments>(R"({"memoryReference":"-4000", "count": 20})");