!fixup handle creating vector false constant

Author: fhahn

llvm/lib/Analysis/InstructionSimplify.cpp

@@ -5252,7 +5252,7 @@ static Value *simplifyExtractValueInst(Value *Agg, ArrayRef<unsigned> Idxs,
     if (Idxs[0] == 0)
       return V;
     assert(Idxs[0] == 1 && "invalid index");
-    return getFalse(IntegerType::get(V->getContext(), 1));
+    return getFalse(CmpInst::makeCmpResultType(V->getType()));
   }
 
   return nullptr;

llvm/test/Transforms/InstSimplify/fold-intrinsics.ll

@@ -615,6 +615,8 @@ declare void @use.i32(i32, i1)
 
 define void @umul_extractvalue(ptr %P, i32 %x) {
 ; CHECK-LABEL: @umul_extractvalue(
+; CHECK-NEXT:    call void @use.i32(i32 [[X:%.*]], i1 false)
+; CHECK-NEXT:    call void @use.i32(i32 [[X]], i1 false)
 ; CHECK-NEXT:    [[UMUL_3:%.*]] = call { i32, i1 } @llvm.umul.with.overflow.i32(i32 2, i32 [[X]])
 ; CHECK-NEXT:    [[R_3:%.*]] = extractvalue { i32, i1 } [[UMUL_3]], 0
 ; CHECK-NEXT:    [[OV_3:%.*]] = extractvalue { i32, i1 } [[UMUL_3]], 1
@@ -643,14 +645,8 @@ declare void @use.4xi32(<4 x i32>, <4 x i1>)
 
 define void @umul_extractvalue_vec(ptr %P, <4 x i32> %x) {
 ; CHECK-LABEL: @umul_extractvalue_vec(
-; CHECK-NEXT:    [[UMUL_1:%.*]] = call { <4 x i32>, <4 x i1> } @llvm.umul.with.overflow.v4i32(<4 x i32> [[X:%.*]], <4 x i32> splat (i32 1))
-; CHECK-NEXT:    [[R_1:%.*]] = extractvalue { <4 x i32>, <4 x i1> } [[UMUL_1]], 0
-; CHECK-NEXT:    [[OV_1:%.*]] = extractvalue { <4 x i32>, <4 x i1> } [[UMUL_1]], 1
-; CHECK-NEXT:    call void @use.4xi32(<4 x i32> [[R_1]], <4 x i1> [[OV_1]])
-; CHECK-NEXT:    [[UMUL_2:%.*]] = call { <4 x i32>, <4 x i1> } @llvm.umul.with.overflow.v4i32(<4 x i32> splat (i32 1), <4 x i32> [[X]])
-; CHECK-NEXT:    [[R_2:%.*]] = extractvalue { <4 x i32>, <4 x i1> } [[UMUL_2]], 0
-; CHECK-NEXT:    [[OV_2:%.*]] = extractvalue { <4 x i32>, <4 x i1> } [[UMUL_2]], 1
-; CHECK-NEXT:    call void @use.4xi32(<4 x i32> [[R_2]], <4 x i1> [[OV_2]])
+; CHECK-NEXT:    call void @use.4xi32(<4 x i32> [[X:%.*]], <4 x i1> zeroinitializer)
+; CHECK-NEXT:    call void @use.4xi32(<4 x i32> [[X]], <4 x i1> zeroinitializer)
 ; CHECK-NEXT:    [[UMUL_3:%.*]] = call { <4 x i32>, <4 x i1> } @llvm.umul.with.overflow.v4i32(<4 x i32> splat (i32 2), <4 x i32> [[X]])
 ; CHECK-NEXT:    [[R_3:%.*]] = extractvalue { <4 x i32>, <4 x i1> } [[UMUL_3]], 0
 ; CHECK-NEXT:    [[OV_3:%.*]] = extractvalue { <4 x i32>, <4 x i1> } [[UMUL_3]], 1