Simplify the loop in layout

s-barannikov · s-barannikov · commit a3676eda47a6 · 2024-12-13T00:06:46.000+03:00
diff --git a/llvm/utils/TableGen/Basic/SequenceToOffsetTable.h b/llvm/utils/TableGen/Basic/SequenceToOffsetTable.h
@@ -116,9 +116,12 @@ class SequenceToOffsetTable {
     for (typename SeqMap::iterator I = Seqs.begin(), E = Seqs.end(); I != E;
          ++I) {
       I->second = Entries;
-      // Include space for a terminator.
-      Entries += I->first.size() + Terminator.has_value();
+      Entries += I->first.size();
     }
+
+    // Include space for terminators.
+    if (Terminator)
+      Entries += Seqs.size();
   }
 
   /// get - Returns the offset of Seq in the final table.

Original file line number	Diff line number	Diff line change
`@@ -116,9 +116,12 @@ class SequenceToOffsetTable {`
`116`	`116`	`for (typename SeqMap::iterator I = Seqs.begin(), E = Seqs.end(); I != E;`
`117`	`117`	`++I) {`
`118`	`118`	`I->second = Entries;`
`119`		`- // Include space for a terminator.`
`120`		`- Entries += I->first.size() + Terminator.has_value();`
	`119`	`+ Entries += I->first.size();`
`121`	`120`	`}`
	`121`	`+`
	`122`	`+ // Include space for terminators.`
	`123`	`+ if (Terminator)`
	`124`	`+ Entries += Seqs.size();`
`122`	`125`	`}`
`123`	`126`
`124`	`127`	`/// get - Returns the offset of Seq in the final table.`