Skip to content

Commit a3810ab

Browse files
committed
[InstCombine] Fix comments. NFC.
1 parent fa34cf1 commit a3810ab

File tree

4 files changed

+9
-13
lines changed

4 files changed

+9
-13
lines changed

llvm/test/Analysis/ValueTracking/numsignbits-from-assume.ll

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,6 @@
11
; NOTE: Assertions have been autogenerated by utils/update_test_checks.py
22
; RUN: opt < %s -passes=instcombine -S | FileCheck %s
33

4-
; FIXME: This does not currently reach a fix point, because an assume can only
5-
; be propagated backwards after its argument has been simplified.
6-
74
define i32 @computeNumSignBits_add1(i32 %in) {
85
; CHECK-LABEL: @computeNumSignBits_add1(
96
; CHECK-NEXT: [[ADD:%.*]] = add i32 [[IN:%.*]], 1

llvm/test/Transforms/InstCombine/shift.ll

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,6 @@
11
; NOTE: Assertions have been autogenerated by utils/update_test_checks.py
22
; RUN: opt < %s -passes=instcombine -S | FileCheck %s
33

4-
; The fuzzer-generated @ashr_out_of_range test case does not reach a fixpoint,
5-
; because a logical and it not relaxed to a bitwise and in one iteration.
6-
74
declare void @use(i64)
85
declare void @use_i32(i32)
96

@@ -1735,6 +1732,9 @@ define i177 @lshr_out_of_range2(i177 %Y, ptr %A2, ptr %ptr) {
17351732
ret i177 %B1
17361733
}
17371734

1735+
; The fuzzer-generated @ashr_out_of_range test case does not reach a fixpoint,
1736+
; because a logical and it not relaxed to a bitwise and in one iteration.
1737+
17381738
; OSS Fuzz #5032
17391739
; https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=5032
17401740
define void @ashr_out_of_range(ptr %A) "instcombine-no-verify-fixpoint" {

llvm/test/Transforms/InstCombine/sink_instruction.ll

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,6 @@
11
; NOTE: Assertions have been autogenerated by utils/update_test_checks.py
22
; RUN: opt -passes=instcombine -S < %s | FileCheck %s
33

4-
; We fail to reach a fixpoint, because sunk instructions get revisited too
5-
; early. In @test2 the sunk add is revisited before the dominating condition
6-
; is visited and added to the DomConditionCache.
7-
84
;; This tests that the instructions in the entry blocks are sunk into each
95
;; arm of the 'if'.
106

@@ -31,6 +27,9 @@ endif: ; preds = %entry
3127
ret i32 %tmp.2
3228
}
3329

30+
; We fail to reach a fixpoint, because sunk instructions get revisited too
31+
; early. In @test2 the sunk add is revisited before the dominating condition
32+
; is visited and added to the DomConditionCache.
3433

3534
;; PHI use, sink divide before call.
3635
define i32 @test2(i32 %x) nounwind ssp "instcombine-no-verify-fixpoint" {

llvm/test/Transforms/PGOProfile/chr.ll

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,6 @@
11
; NOTE: Assertions have been autogenerated by utils/update_test_checks.py
22
; RUN: opt < %s -passes='require<profile-summary>,function(chr,instcombine,simplifycfg)' -S | FileCheck %s
33

4-
; FIXME: This does not currently reach a fix point, because we don't make use
5-
; of a freeze that is pushed up the instruction chain later.
6-
74
declare void @foo()
85
declare void @bar()
96

@@ -1910,6 +1907,9 @@ bb4:
19101907
ret i32 %v13
19111908
}
19121909

1910+
; FIXME: This does not currently reach a fix point, because we don't make use
1911+
; of a freeze that is pushed up the instruction chain later.
1912+
19131913
; Test the case where two scopes share a common instruction to hoist (%cmp.i).
19141914
; Two scopes would hoist it to their hoist points, but since the outer scope
19151915
; hoists (entry/bb6-9) it first to its hoist point, it'd be wrong (causing bad

0 commit comments

Comments
 (0)