Prevent fir.convert operation from being generated between logical and pointer types

Author: ceseo

flang/lib/Lower/ConvertCall.cpp

@@ -151,17 +151,6 @@ static bool mustCastFuncOpToCopeWithImplicitInterfaceMismatch(
       if (actualType != dummyType &&
           !fir::ConvertOp::canBeConverted(actualType, dummyType))
         return true;
-
-  // For %VAL arguments with implicit interfaces, we need to force an indirect
-  // call to ensure consistent behavior regardless of whether the procedure
-  // is defined in the same compilation unit or not. Check for mismatches
-  // where a by-value call site expects a reference type in the actual
-  // function definition.
-  for (auto [actualType, dummyType] :
-       llvm::zip(callSiteType.getInputs(), funcOpType.getInputs()))
-    if (!fir::isa_ref_type(actualType) && fir::isa_ref_type(dummyType) &&
-        fir::dyn_cast_ptrEleTy(dummyType) == actualType)
-      return true;
   return false;
 }
 

flang/lib/Optimizer/Dialect/FIROps.cpp

@@ -1521,8 +1521,8 @@ bool fir::ConvertOp::canBeConverted(mlir::Type inType, mlir::Type outType) {
          (isInteger(inType) && isFloatCompatible(outType)) ||
          (isFloatCompatible(inType) && isInteger(outType)) ||
          (isFloatCompatible(inType) && isFloatCompatible(outType)) ||
-         (isIntegerCompatible(inType) && isPointerCompatible(outType)) ||
-         (isPointerCompatible(inType) && isIntegerCompatible(outType)) ||
+         (isInteger(inType) && isPointerCompatible(outType)) ||
+         (isPointerCompatible(inType) && isInteger(outType)) ||
          (mlir::isa<fir::BoxType>(inType) &&
           mlir::isa<fir::BoxType>(outType)) ||
          (mlir::isa<fir::BoxProcType>(inType) &&