Do not handle BoxCharType in hasDynamicSize because hasDynamicSize helper is supposed

to return false for pointer-like types which boxchar is. Clients should use a "preprocessing"
helper such as dyn_cast_ptrOrBoxEleTy before calling hasDynamicSize as shown below

bool HasDynamicSize = fir::hasDynamicSize(fir::dyn_cast_ptrOrBoxEleTy(boxCharType));

Author: bhandarkar-pranav

flang/lib/Optimizer/Dialect/FIRType.cpp

@@ -285,9 +285,6 @@ bool hasDynamicSize(mlir::Type t) {
     return true;
   if (auto rec = mlir::dyn_cast<fir::RecordType>(t))
     return hasDynamicSize(rec);
-  if (auto boxChar = mlir::dyn_cast<fir::BoxCharType>(t)) {
-    return characterWithDynamicLen(boxChar.getEleTy());
-  }
   return false;
 }