Skip to content

Commit a48b137

Browse files
committed
Remove a flag that would set the ".eh" symbol as .globl. MachO was the only one
who used this flag, and it now emits CFI and doesn't emit this anymore. All other targets left this flag "false". <rdar://problem/8486371> llvm-svn: 130918
1 parent 4587d81 commit a48b137

File tree

4 files changed

+0
-18
lines changed

4 files changed

+0
-18
lines changed

llvm/include/llvm/Target/TargetLoweringObjectFile.h

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -97,10 +97,6 @@ class TargetLoweringObjectFile {
9797
/// weak_definition of constant 0 for an omitted EH frame.
9898
bool SupportsWeakOmittedEHFrame;
9999

100-
/// IsFunctionEHSymbolGlobal - This flag is set to true if the ".eh" symbol
101-
/// for a function should be marked .globl.
102-
bool IsFunctionEHSymbolGlobal;
103-
104100
/// IsFunctionEHFrameSymbolPrivate - This flag is set to true if the
105101
/// "EH_frame" symbol for EH information should be an assembler temporary (aka
106102
/// private linkage, aka an L or .L label) or false if it should be a normal
@@ -119,9 +115,6 @@ class TargetLoweringObjectFile {
119115
Ctx = &ctx;
120116
}
121117

122-
bool isFunctionEHSymbolGlobal() const {
123-
return IsFunctionEHSymbolGlobal;
124-
}
125118
bool isFunctionEHFrameSymbolPrivate() const {
126119
return IsFunctionEHFrameSymbolPrivate;
127120
}

llvm/lib/CodeGen/AsmPrinter/DwarfTableException.cpp

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -172,11 +172,6 @@ void DwarfTableException::EmitFDE(const FunctionEHFrameInfo &EHFrameInfo) {
172172

173173
Asm->OutStreamer.SwitchSection(TLOF.getEHFrameSection());
174174

175-
// Externally visible entry into the functions eh frame info. If the
176-
// corresponding function is static, this should not be externally visible.
177-
if (!TheFunc->hasLocalLinkage() && TLOF.isFunctionEHSymbolGlobal())
178-
Asm->OutStreamer.EmitSymbolAttribute(EHFrameInfo.FunctionEHSym,MCSA_Global);
179-
180175
// If corresponding function is weak definition, this should be too.
181176
if (TheFunc->isWeakForLinker() && Asm->MAI->getWeakDefDirective())
182177
Asm->OutStreamer.EmitSymbolAttribute(EHFrameInfo.FunctionEHSym,

llvm/lib/CodeGen/TargetLoweringObjectFileImpl.cpp

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -484,11 +484,6 @@ getExprForDwarfGlobalReference(const GlobalValue *GV, Mangler *Mang,
484484

485485
void TargetLoweringObjectFileMachO::Initialize(MCContext &Ctx,
486486
const TargetMachine &TM) {
487-
// _foo.eh symbols are currently always exported so that the linker knows
488-
// about them. This is not necessary on 10.6 and later, but it
489-
// doesn't hurt anything.
490-
// FIXME: I need to get this from Triple.
491-
IsFunctionEHSymbolGlobal = true;
492487
IsFunctionEHFrameSymbolPrivate = false;
493488
SupportsWeakOmittedEHFrame = false;
494489

llvm/lib/Target/TargetLoweringObjectFile.cpp

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,6 @@ TargetLoweringObjectFile::TargetLoweringObjectFile() : Ctx(0) {
5858
DwarfRangesSection = 0;
5959
DwarfMacroInfoSection = 0;
6060

61-
IsFunctionEHSymbolGlobal = false;
6261
IsFunctionEHFrameSymbolPrivate = true;
6362
SupportsWeakOmittedEHFrame = true;
6463
}

0 commit comments

Comments
 (0)