Skip to content

Commit a4c4c12

Browse files
committed
Use switch in GetVendorDWARFOpcodeSize
1 parent c9cea26 commit a4c4c12

File tree

1 file changed

+12
-3
lines changed

1 file changed

+12
-3
lines changed

lldb/source/Plugins/SymbolFile/DWARF/SymbolFileWasm.cpp

Lines changed: 12 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -30,10 +30,19 @@ SymbolFileWasm::GetVendorDWARFOpcodeSize(const DataExtractor &data,
3030

3131
lldb::offset_t offset = data_offset;
3232
const uint8_t wasm_op = data.GetU8(&offset);
33-
if (wasm_op == eWasmTagOperandStack)
34-
data.GetU32(&offset);
35-
else
33+
switch (wasm_op) {
34+
case 0: // LOCAL
35+
case 1: // GLOBAL_FIXED
36+
case 2: // OPERAND_STACK
3637
data.GetULEB128(&offset);
38+
break;
39+
case 3: // GLOBAL_RELOC
40+
data.GetU32(&offset);
41+
break;
42+
default:
43+
return LLDB_INVALID_OFFSET;
44+
}
45+
3746
return offset - data_offset;
3847
}
3948

0 commit comments

Comments
 (0)