Skip to content

Commit a500961

Browse files
stellar-ariastellar-aria
committed
Fix tests and docs
1 parent 332ceb9 commit a500961

File tree

3 files changed

+25
-23
lines changed

3 files changed

+25
-23
lines changed

‎clang-tools-extra/clang-tidy/readability/UseNumericLimitsCheck.cpp‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -145,7 +145,7 @@ void UseNumericLimitsCheck::check(const MatchFinder::MatchResult &Result) {
145145

146146
diag(Location,
147147
"the constant '%0' is being utilized; consider using '%1' instead")
148-
<< std::to_string(SourceValue) << Replacement
148+
<< SourceValue << Replacement
149149
<< FixItHint::CreateReplacement(Range, Replacement)
150150
<< Inserter.createIncludeInsertion(
151151
Result.SourceManager->getFileID(Location), "<limits>");

‎clang-tools-extra/docs/ReleaseNotes.rst‎

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -149,8 +149,10 @@ New checks
149149
the pointee type also has a ``reset`` method.
150150

151151
- New :doc:`readability-use-numeric-limits
152-
<clang-tidy/checks/readability/use-numeric-limits>` check to replace certain
153-
integer literals with ``std::numeric_limits`` calls.
152+
<clang-tidy/checks/readability/use-numeric-limits>` check.
153+
154+
Finds certain integer literals and suggests replacing them with equivalent
155+
``std::numeric_limits`` calls.
154156

155157
New check aliases
156158
^^^^^^^^^^^^^^^^^

‎clang-tools-extra/test/clang-tidy/checkers/readability/use-numeric-limits.cpp‎

Lines changed: 20 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -2,83 +2,83 @@
22
#include <stdint.h>
33

44
void Invalid() {
5-
// CHECK-MESSAGES: :[[@LINE+2]]:14: warning: The constant -128 is being utilized. Consider using std::numeric_limits<int8_t>::min() instead [readability-use-numeric-limits]
5+
// CHECK-MESSAGES: :[[@LINE+2]]:14: warning: the constant '-128' is being utilized; consider using 'std::numeric_limits<int8_t>::min()' instead [readability-use-numeric-limits]
66
// CHECK-FIXES: int8_t a = std::numeric_limits<int8_t>::min();
77
int8_t a = -128;
88

9-
// CHECK-MESSAGES: :[[@LINE+2]]:14: warning: The constant 127 is being utilized. Consider using std::numeric_limits<int8_t>::max() instead [readability-use-numeric-limits]
9+
// CHECK-MESSAGES: :[[@LINE+2]]:14: warning: the constant '127' is being utilized; consider using 'std::numeric_limits<int8_t>::max()' instead [readability-use-numeric-limits]
1010
// CHECK-FIXES: int8_t b = std::numeric_limits<int8_t>::max();
1111
int8_t b = +127;
1212

13-
// CHECK-MESSAGES: :[[@LINE+2]]:14: warning: The constant 127 is being utilized. Consider using std::numeric_limits<int8_t>::max() instead [readability-use-numeric-limits]
13+
// CHECK-MESSAGES: :[[@LINE+2]]:14: warning: the constant '127' is being utilized; consider using 'std::numeric_limits<int8_t>::max()' instead [readability-use-numeric-limits]
1414
// CHECK-FIXES: int8_t c = std::numeric_limits<int8_t>::max();
1515
int8_t c = 127;
1616

17-
// CHECK-MESSAGES: :[[@LINE+2]]:15: warning: The constant -32768 is being utilized. Consider using std::numeric_limits<int16_t>::min() instead [readability-use-numeric-limits]
17+
// CHECK-MESSAGES: :[[@LINE+2]]:15: warning: the constant '-32768' is being utilized; consider using 'std::numeric_limits<int16_t>::min()' instead [readability-use-numeric-limits]
1818
// CHECK-FIXES: int16_t d = std::numeric_limits<int16_t>::min();
1919
int16_t d = -32768;
2020

21-
// CHECK-MESSAGES: :[[@LINE+2]]:15: warning: The constant 32767 is being utilized. Consider using std::numeric_limits<int16_t>::max() instead [readability-use-numeric-limits]
21+
// CHECK-MESSAGES: :[[@LINE+2]]:15: warning: the constant '32767' is being utilized; consider using 'std::numeric_limits<int16_t>::max()' instead [readability-use-numeric-limits]
2222
// CHECK-FIXES: int16_t e = std::numeric_limits<int16_t>::max();
2323
int16_t e = +32767;
2424

25-
// CHECK-MESSAGES: :[[@LINE+2]]:15: warning: The constant 32767 is being utilized. Consider using std::numeric_limits<int16_t>::max() instead [readability-use-numeric-limits]
25+
// CHECK-MESSAGES: :[[@LINE+2]]:15: warning: the constant '32767' is being utilized; consider using 'std::numeric_limits<int16_t>::max()' instead [readability-use-numeric-limits]
2626
// CHECK-FIXES: int16_t f = std::numeric_limits<int16_t>::max();
2727
int16_t f = 32767;
2828

29-
// CHECK-MESSAGES: :[[@LINE+2]]:15: warning: The constant -2147483648 is being utilized. Consider using std::numeric_limits<int32_t>::min() instead [readability-use-numeric-limits]
29+
// CHECK-MESSAGES: :[[@LINE+2]]:15: warning: the constant '-2147483648' is being utilized; consider using 'std::numeric_limits<int32_t>::min()' instead [readability-use-numeric-limits]
3030
// CHECK-FIXES: int32_t g = std::numeric_limits<int32_t>::min();
3131
int32_t g = -2147483648;
3232

33-
// CHECK-MESSAGES: :[[@LINE+2]]:15: warning: The constant 2147483647 is being utilized. Consider using std::numeric_limits<int32_t>::max() instead [readability-use-numeric-limits]
33+
// CHECK-MESSAGES: :[[@LINE+2]]:15: warning: the constant '2147483647' is being utilized; consider using 'std::numeric_limits<int32_t>::max()' instead [readability-use-numeric-limits]
3434
// CHECK-FIXES: int32_t h = std::numeric_limits<int32_t>::max();
3535
int32_t h = +2147483647;
3636

37-
// CHECK-MESSAGES: :[[@LINE+2]]:15: warning: The constant 2147483647 is being utilized. Consider using std::numeric_limits<int32_t>::max() instead [readability-use-numeric-limits]
37+
// CHECK-MESSAGES: :[[@LINE+2]]:15: warning: the constant '2147483647' is being utilized; consider using 'std::numeric_limits<int32_t>::max()' instead [readability-use-numeric-limits]
3838
// CHECK-FIXES: int32_t i = std::numeric_limits<int32_t>::max();
3939
int32_t i = 2147483647;
4040

41-
// CHECK-MESSAGES: :[[@LINE+2]]:15: warning: The constant -9223372036854775808 is being utilized. Consider using std::numeric_limits<int64_t>::min() instead [readability-use-numeric-limits]
41+
// CHECK-MESSAGES: :[[@LINE+2]]:15: warning: the constant '-9223372036854775808' is being utilized; consider using 'std::numeric_limits<int64_t>::min()' instead [readability-use-numeric-limits]
4242
// CHECK-FIXES: int64_t j = std::numeric_limits<int64_t>::min();
4343
int64_t j = -9223372036854775808;
4444

45-
// CHECK-MESSAGES: :[[@LINE+2]]:15: warning: The constant 9223372036854775807 is being utilized. Consider using std::numeric_limits<int64_t>::max() instead [readability-use-numeric-limits]
45+
// CHECK-MESSAGES: :[[@LINE+2]]:15: warning: the constant '9223372036854775807' is being utilized; consider using 'std::numeric_limits<int64_t>::max()' instead [readability-use-numeric-limits]
4646
// CHECK-FIXES: int64_t k = std::numeric_limits<int64_t>::max();
4747
int64_t k = +9223372036854775807;
4848

49-
// CHECK-MESSAGES: :[[@LINE+2]]:15: warning: The constant 9223372036854775807 is being utilized. Consider using std::numeric_limits<int64_t>::max() instead [readability-use-numeric-limits]
49+
// CHECK-MESSAGES: :[[@LINE+2]]:15: warning: the constant '9223372036854775807' is being utilized; consider using 'std::numeric_limits<int64_t>::max()' instead [readability-use-numeric-limits]
5050
// CHECK-FIXES: int64_t l = std::numeric_limits<int64_t>::max();
5151
int64_t l = 9223372036854775807;
5252

53-
// CHECK-MESSAGES: :[[@LINE+2]]:15: warning: The constant 255 is being utilized. Consider using std::numeric_limits<uint8_t>::max() instead [readability-use-numeric-limits]
53+
// CHECK-MESSAGES: :[[@LINE+2]]:15: warning: the constant '255' is being utilized; consider using 'std::numeric_limits<uint8_t>::max()' instead [readability-use-numeric-limits]
5454
// CHECK-FIXES: uint8_t m = std::numeric_limits<uint8_t>::max();
5555
uint8_t m = 255;
5656

57-
// CHECK-MESSAGES: :[[@LINE+2]]:15: warning: The constant 255 is being utilized. Consider using std::numeric_limits<uint8_t>::max() instead [readability-use-numeric-limits]
57+
// CHECK-MESSAGES: :[[@LINE+2]]:15: warning: the constant '255' is being utilized; consider using 'std::numeric_limits<uint8_t>::max()' instead [readability-use-numeric-limits]
5858
// CHECK-FIXES: uint8_t n = std::numeric_limits<uint8_t>::max();
5959
uint8_t n = +255;
6060

61-
// CHECK-MESSAGES: :[[@LINE+2]]:16: warning: The constant 65535 is being utilized. Consider using std::numeric_limits<uint16_t>::max() instead [readability-use-numeric-limits]
61+
// CHECK-MESSAGES: :[[@LINE+2]]:16: warning: the constant '65535' is being utilized; consider using 'std::numeric_limits<uint16_t>::max()' instead [readability-use-numeric-limits]
6262
// CHECK-FIXES: uint16_t o = std::numeric_limits<uint16_t>::max();
6363
uint16_t o = 65535;
6464

65-
// CHECK-MESSAGES: :[[@LINE+2]]:16: warning: The constant 65535 is being utilized. Consider using std::numeric_limits<uint16_t>::max() instead [readability-use-numeric-limits]
65+
// CHECK-MESSAGES: :[[@LINE+2]]:16: warning: the constant '65535' is being utilized; consider using 'std::numeric_limits<uint16_t>::max()' instead [readability-use-numeric-limits]
6666
// CHECK-FIXES: uint16_t p = std::numeric_limits<uint16_t>::max();
6767
uint16_t p = +65535;
6868

69-
// CHECK-MESSAGES: :[[@LINE+2]]:16: warning: The constant 4294967295 is being utilized. Consider using std::numeric_limits<uint32_t>::max() instead [readability-use-numeric-limits]
69+
// CHECK-MESSAGES: :[[@LINE+2]]:16: warning: the constant '4294967295' is being utilized; consider using 'std::numeric_limits<uint32_t>::max()' instead [readability-use-numeric-limits]
7070
// CHECK-FIXES: uint32_t q = std::numeric_limits<uint32_t>::max();
7171
uint32_t q = 4294967295;
7272

73-
// CHECK-MESSAGES: :[[@LINE+2]]:16: warning: The constant 4294967295 is being utilized. Consider using std::numeric_limits<uint32_t>::max() instead [readability-use-numeric-limits]
73+
// CHECK-MESSAGES: :[[@LINE+2]]:16: warning: the constant '4294967295' is being utilized; consider using 'std::numeric_limits<uint32_t>::max()' instead [readability-use-numeric-limits]
7474
// CHECK-FIXES: uint32_t r = std::numeric_limits<uint32_t>::max();
7575
uint32_t r = +4294967295;
7676

77-
// CHECK-MESSAGES: :[[@LINE+2]]:16: warning: The constant 18446744073709551615 is being utilized. Consider using std::numeric_limits<uint64_t>::max() instead [readability-use-numeric-limits]
77+
// CHECK-MESSAGES: :[[@LINE+2]]:16: warning: the constant '18446744073709551615' is being utilized; consider using 'std::numeric_limits<uint64_t>::max()' instead [readability-use-numeric-limits]
7878
// CHECK-FIXES: uint64_t s = std::numeric_limits<uint64_t>::max();
7979
uint64_t s = 18446744073709551615;
8080

81-
// CHECK-MESSAGES: :[[@LINE+2]]:16: warning: The constant 18446744073709551615 is being utilized. Consider using std::numeric_limits<uint64_t>::max() instead [readability-use-numeric-limits]
81+
// CHECK-MESSAGES: :[[@LINE+2]]:16: warning: the constant '18446744073709551615' is being utilized; consider using 'std::numeric_limits<uint64_t>::max()' instead [readability-use-numeric-limits]
8282
// CHECK-FIXES: uint64_t t = std::numeric_limits<uint64_t>::max();
8383
uint64_t t = +18446744073709551615;
8484
}

0 commit comments

Comments
 (0)