plain enum

Author: chelini

mlir/include/mlir/Dialect/Arith/IR/ArithBase.td

@@ -191,17 +191,17 @@ def Arith_RoundingModeAttr : I32EnumAttr<
 
 // The default mode. Denormals are preserved and processed as defined 
 // by IEEE 754 rules.
-def Arith_DenormalModeIEEE          : I32BitEnumAttrCaseNone<"ieee">;
+def Arith_DenormalModeIEEE          : I32EnumAttrCase<"ieee", 0>;
 
 // A mode where denormal numbers are flushed to zero, but the sign of the zero 
 // (+0 or -0) is preserved.
-def Arith_DenormalModePreserveSign  : I32BitEnumAttrCase<"preserve_sign", 1>;
+def Arith_DenormalModePreserveSign  : I32EnumAttrCase<"preserve_sign", 1>;
 
 // A mode where all denormal numbers are flushed to positive zero (+0), 
 // ignoring the sign of the original number.
-def Arith_DenormalModePositiveZero  : I32BitEnumAttrCase<"positive_zero",  2>;
+def Arith_DenormalModePositiveZero  : I32EnumAttrCase<"positive_zero",  2>;
 
-def Arith_DenormalMode : I32BitEnumAttr<
+def Arith_DenormalMode : I32EnumAttr<
     "DenormalMode", "denormal mode arith",
     [Arith_DenormalModeIEEE, Arith_DenormalModePreserveSign, 
      Arith_DenormalModePositiveZero]> {
@@ -212,7 +212,6 @@ def Arith_DenormalMode : I32BitEnumAttr<
 def Arith_DenormalModeAttr :
     EnumAttr<Arith_Dialect, Arith_DenormalMode, "denormal"> {
   let assemblyFormat = "`<` $value `>`";
-  let genVerifyDecl = 1;
 }
 
 #endif // ARITH_BASE

mlir/lib/Dialect/Arith/IR/ArithOps.cpp

@@ -2643,20 +2643,6 @@ Value mlir::arith::getReductionOp(AtomicRMWKind op, OpBuilder &builder,
   return nullptr;
 }
 
-//===----------------------------------------------------------------------===//
-// DenormalModeAttr
-//===----------------------------------------------------------------------===//
-
-LogicalResult DenormalModeAttr::verify(
-    llvm::function_ref<mlir::InFlightDiagnostic()> emitError,
-    DenormalMode mode) {
-  auto value = static_cast<uint32_t>(mode);
-  bool isSingleBitSet = (value & (value - 1)) == 0;
-  if (!isSingleBitSet)
-    return emitError() << "expected only a single denormal mode";
-  return success();
-}
-
 //===----------------------------------------------------------------------===//
 // TableGen'd op method definitions
 //===----------------------------------------------------------------------===//

mlir/test/Dialect/Arith/invalid.mlir

@@ -853,11 +853,3 @@ func.func @select_tensor_encoding(
   %0 = arith.select %arg0, %arg1, %arg2 : tensor<8xi1, "bar">, tensor<8xi32, "foo">
   return %0 : tensor<8xi32, "foo">
 }
-
-// -----
-
-func.func @test_denormal_mode(%arg0: f32, %arg1: f32) -> f32 {
-  // expected-error @below{{expected only a single denormal mode}}
-  %0 = arith.subf %arg0, %arg1 denormal<preserve_sign | positive_zero> : f32
-  return %0 : f32
-}