Target::GetTargetSessionName returns llvm::StringRef

Author: qxy11

lldb/include/lldb/Target/Target.h

@@ -631,7 +631,7 @@ class Target : public std::enable_shared_from_this<Target>,
   ///
   /// \return
   ///     The target session name for this target.
-  const std::string &GetTargetSessionName() { return m_target_session_name; }
+  llvm::StringRef GetTargetSessionName() { return m_target_session_name; }
 
   /// Set the target session name for this target.
   ///

lldb/source/API/SBTarget.cpp

@@ -1645,7 +1645,7 @@ const char *SBTarget::GetTargetSessionName() const {
   LLDB_INSTRUMENT_VA(this);
 
   if (TargetSP target_sp = GetSP())
-    return ConstString(target_sp->GetTargetSessionName().data()).AsCString();
+    return ConstString(target_sp->GetTargetSessionName()).AsCString();
   return nullptr;
 }
 

lldb/tools/lldb-dap/DAPSessionManager.cpp

@@ -1,4 +1,4 @@
-//===-- DAPSessionManager.cpp ----------------------------------*- C++ -*-===//
+//===----------------------------------------------------------------------===//
 //
 // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
 // See https://llvm.org/LICENSE.txt for license information.

lldb/tools/lldb-dap/DAPSessionManager.h

@@ -1,10 +1,16 @@
-//===-- DAPSessionManager.h ------------------------------------*- C++ -*-===//
+//===----------------------------------------------------------------------===//
 //
 // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
 // See https://llvm.org/LICENSE.txt for license information.
 // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
 //
 //===----------------------------------------------------------------------===//
+///
+/// \file
+/// This file contains the declarations of the DAPSessionManager and ManagedEventThread classes,
+/// which are used to multiple concurrent DAP sessions in a single lldb-dap process.
+///
+//===----------------------------------------------------------------------===//
 
 #ifndef LLDB_TOOLS_LLDB_DAP_DAPSESSIONMANAGER_H
 #define LLDB_TOOLS_LLDB_DAP_DAPSESSIONMANAGER_H