Skip to content

Commit a5c23a3

Browse files
committed
[llvm-exegesis] [AArch64] Fixed comment clarity on hacky fix by omitting OPERAND_UNKNOWN
1 parent ac07228 commit a5c23a3

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

llvm/tools/llvm-exegesis/lib/AArch64/Target.cpp

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -165,11 +165,11 @@ Error ExegesisAArch64Target::randomizeTargetMCOperand(
165165
// Requires OperandType to be defined for such opcode's operands in AArch64
166166
// tablegen files. And omit introduced OperandType(s).
167167

168-
// Hacky temporary fix works by defaulting all OPERAND_UNKNOWN to
169-
// immediate value 0, but this introduce illegal instruction error for below
170-
// system instructions will need to be omitted with OperandType or opcode
171-
// specific values to avoid generating invalid encodings or unreliable
172-
// benchmark results for these system-level instructions.
168+
// Hacky Fix: Defaulting all OPERAND_UNKNOWN to immediate value 0 works with a
169+
// limitation that it introduces illegal instruction error for system
170+
// instructions. System instructions will need to be omitted with OperandType
171+
// or opcode specific values to avoid generating invalid encodings or
172+
// unreliable benchmark results for these system-level instructions.
173173
// Implement opcode-specific immediate value handling for system instrs:
174174
// - MRS/MSR: Use valid system register encodings (e.g., NZCV, FPCR, FPSR)
175175
// - MSRpstatesvcrImm1: Use valid PSTATE field encodings (e.g., SPSel,

0 commit comments

Comments
 (0)