[MLIR] Apply clang-tidy fixes for misc-use-internal-linkage in Var.cpp (NFC)

joker-eph · joker-eph · commit a5fe4e44800c · 2025-08-31T13:12:08.000-07:00
diff --git a/mlir/lib/Dialect/SparseTensor/IR/Detail/Var.cpp b/mlir/lib/Dialect/SparseTensor/IR/Detail/Var.cpp
@@ -156,13 +156,14 @@ minSMLoc(AsmParser &parser, llvm::SMLoc sm1, llvm::SMLoc sm2) {
   return pair1 <= pair2 ? sm1 : sm2;
 }
 
-bool isInternalConsistent(VarEnv const &env, VarInfo::ID id, StringRef name) {
+static bool isInternalConsistent(VarEnv const &env, VarInfo::ID id,
+                                 StringRef name) {
   const auto &var = env.access(id);
   return (var.getName() == name && var.getID() == id);
 }
 
-bool isUsageConsistent(VarEnv const &env, VarInfo::ID id, llvm::SMLoc loc,
-                       VarKind vk) {
+static bool isUsageConsistent(VarEnv const &env, VarInfo::ID id,
+                              llvm::SMLoc loc, VarKind vk) {
   const auto &var = env.access(id);
   return var.getKind() == vk;
 }

Original file line number	Diff line number	Diff line change
`@@ -156,13 +156,14 @@ minSMLoc(AsmParser &parser, llvm::SMLoc sm1, llvm::SMLoc sm2) {`
`156`	`156`	`return pair1 <= pair2 ? sm1 : sm2;`
`157`	`157`	`}`
`158`	`158`
`159`		`-bool isInternalConsistent(VarEnv const &env, VarInfo::ID id, StringRef name) {`
	`159`	`+static bool isInternalConsistent(VarEnv const &env, VarInfo::ID id,`
	`160`	`+ StringRef name) {`
`160`	`161`	`const auto &var = env.access(id);`
`161`	`162`	`return (var.getName() == name && var.getID() == id);`
`162`	`163`	`}`
`163`	`164`
`164`		`-bool isUsageConsistent(VarEnv const &env, VarInfo::ID id, llvm::SMLoc loc,`
`165`		`- VarKind vk) {`
	`165`	`+static bool isUsageConsistent(VarEnv const &env, VarInfo::ID id,`
	`166`	`+ llvm::SMLoc loc, VarKind vk) {`
`166`	`167`	`const auto &var = env.access(id);`
`167`	`168`	`return var.getKind() == vk;`
`168`	`169`	`}`