Address review feedback

andykaylor · andykaylor · commit a60d8427c6ae · 2025-08-18T13:57:30.000-07:00
diff --git a/clang/include/clang/CIR/Dialect/Builder/CIRBaseBuilder.h b/clang/include/clang/CIR/Dialect/Builder/CIRBaseBuilder.h
@@ -162,7 +162,8 @@ class CIRBaseBuilderTy : public mlir::OpBuilder {
     mlir::IntegerAttr alignmentAttr = getAlignmentAttr(alignment);
     assert(!cir::MissingFeatures::opLoadStoreVolatile());
     assert(!cir::MissingFeatures::opLoadStoreMemOrder());
-    return create<cir::LoadOp>(loc, ptr, /*isDeref=*/false, alignmentAttr);
+    return cir::LoadOp::create(*this, loc, ptr, /*isDeref=*/false,
+                               alignmentAttr);
   }
 
   mlir::Value createAlignedLoad(mlir::Location loc, mlir::Value ptr,

Original file line number	Diff line number	Diff line change
`@@ -162,7 +162,8 @@ class CIRBaseBuilderTy : public mlir::OpBuilder {`
`162`	`162`	`mlir::IntegerAttr alignmentAttr = getAlignmentAttr(alignment);`
`163`	`163`	`assert(!cir::MissingFeatures::opLoadStoreVolatile());`
`164`	`164`	`assert(!cir::MissingFeatures::opLoadStoreMemOrder());`
`165`		`- return create<cir::LoadOp>(loc, ptr, /isDeref=/false, alignmentAttr);`
	`165`	`+ return cir::LoadOp::create(this, loc, ptr, /isDeref=*/false,`
	`166`	`+ alignmentAttr);`
`166`	`167`	`}`
`167`	`168`
`168`	`169`	`mlir::Value createAlignedLoad(mlir::Location loc, mlir::Value ptr,`