Update tests for f16tof32()

Replace the f16tof32 test with an unpackhalf2x16 test, to match changes
to the spirv codegen for f16to32 support.
Adjust the f16tof32-errors.hlsl diagnostics test.

Author: Tim Corringham

clang/test/SemaHLSL/BuiltIns/f16tof32-errors.hlsl

@@ -1,4 +1,4 @@
-// RUN: %clang_cc1 -finclude-default-header -x hlsl -triple dxil-pc-shadermodel6.6-library %s -fnative-half-type -emit-llvm-only -disable-llvm-passes -verify
+// RUN: %clang_cc1 -finclude-default-header -x hlsl -triple dxil-pc-shadermodel6.6-library %s -fnative-int16-type -emit-llvm-only -disable-llvm-passes -verify
 
 float builtin_f16tof32_too_few_arg() {
   return __builtin_hlsl_elementwise_f16tof32();
@@ -22,12 +22,12 @@ float builtin_f16tof32_bool4(bool4 p0) {
   // expected-error@-1 {{1st argument must be a scalar or vector of unsigned integer types (was 'bool4' (aka 'vector<bool, 4>')}}
 }
 
-float builtin_f16tof32_int16_t(int16_t p0) {
+float builtin_f16tof32_short(short p0) {
   return __builtin_hlsl_elementwise_f16tof32(p0);
-  // expected-error@-1 {{1st argument must be a scalar or vector of unsigned integer types (was 'int16_t' (aka 'short'))}}
+  // expected-error@-1 {{1st argument must be a scalar or vector of unsigned integer types (was 'short')}}
 }
 
-float builtin_f16tof32_int16_t(unsigned short p0) {
+float builtin_f16tof32_unsigned_short(unsigned short p0) {
   return __builtin_hlsl_elementwise_f16tof32(p0);
   // expected-error@-1 {{incorrect number of bits in integer (expected 32 bits, have 16)}}
 }
@@ -84,13 +84,13 @@ float f16tof32_bool(bool p0) {
 
 float f16tof32_bool3(bool3 p0) {
   return f16tof32(p0);
-  // expected-error@-1 {{1st argument must be a scalar or vector of unsigned integer types (was 'bool3' (aka 'vector<bool, 3>')}}
+  // expected-error@-1 {{1st argument must be a scalar or vector of unsigned integer types (was 'bool3' (aka 'vector<bool, 3>'))}}
 }
 
 
-float f16tof32_int16_t(int16_t p0) {
+float f16tof32_int16_t(short p0) {
   return f16tof32(p0);
-  // expected-error@-1 {{1st argument must be a scalar or vector of unsigned integer types (was 'int16_t' (aka 'short'))}}
+  // expected-error@-1 {{1st argument must be a scalar or vector of unsigned integer types (was 'short')}}
 }
 
 float f16tof32_int16_t(unsigned short p0) {

llvm/test/CodeGen/SPIRV/hlsl-intrinsics/f16tof32.ll

@@ -0,0 +1,18 @@
+; RUN: llc -O0 -verify-machineinstrs -mtriple=spirv-unknown-vulkan %s -o - | FileCheck %s
+; RUN: %if spirv-tools %{ llc -O0 -mtriple=spirv-unknown-vulkan %s -o - -filetype=obj | spirv-val %}
+
+; CHECK-DAG: [[SET:%.*]] = OpExtInstImport "GLSL.std.450"
+; CHECK-DAG: [[UINT:%.*]] = OpTypeInt 32 0
+; CHECK-DAG: [[FLOAT:%.*]] = OpTypeFloat 32
+; CHECK-DAG: [[FLOAT2:%.*]] = OpTypeVector [[FLOAT]] 2
+
+; CHECK: [[P0:%.*]] = OpFunctionParameter [[UINT]]
+; CHECK: [[UNPACK2:%.*]] = OpExtInst [[FLOAT2]] [[SET]] UnpackHalf2x16 [[P0]]
+; CHECK: [[UNPACK:%.*]] = OpCompositeExtract [[FLOAT]] [[UNPACK2]] 0
+; CHECK: OpReturnValue [[UNPACK]]
+define hidden spir_func noundef nofpclass(nan inf) float @_Z9test_funcj(i32 noundef %0) local_unnamed_addr #0 {
+  %2 = tail call reassoc nnan ninf nsz arcp afn <2 x float> @llvm.spv.unpackhalf2x16.v2f32(i32 %0)
+  %3 = extractelement <2 x float> %2, i64 0
+  ret float %3
+}
+