Apply feedback

Author: monthdev

clang/lib/AST/ByteCode/InterpBuiltin.cpp

@@ -3816,11 +3816,12 @@ bool InterpretBuiltin(InterpState &S, CodePtr OpPC, const CallExpr *Call,
   case X86::BI__builtin_ia32_psignd128:
   case X86::BI__builtin_ia32_psignd256:
     return interp__builtin_elementwise_int_binop(
-        S, OpPC, Call, [](const APSInt &AElem, const APSInt &BElem) -> APInt {
-          return BElem[BElem.getBitWidth() - 1]
-                     ? static_cast<const APInt &>(-AElem)
-                 : BElem.isZero() ? APInt(AElem.getBitWidth(), 0)
-                                  : static_cast<const APInt &>(AElem);
+        S, OpPC, Call, [](const APInt &AElem, const APInt &BElem) {
+       if (BElem.isZero())
+            return APInt::getZero(AElem.getBitWidth());
+          if (BElem.isNegative())
+            return -AElem;
+          return AElem;
         });
 
   case clang::X86::BI__builtin_ia32_pavgb128:

clang/lib/AST/ExprConstant.cpp

@@ -12318,11 +12318,13 @@ bool VectorExprEvaluator::VisitCallExpr(const CallExpr *E) {
   case X86::BI__builtin_ia32_psignw256:
   case X86::BI__builtin_ia32_psignd128:
   case X86::BI__builtin_ia32_psignd256:
-    return EvaluateBinOpExpr([](const APSInt &AElem,
-                                const APSInt &BElem) -> APInt {
-      return BElem[BElem.getBitWidth() - 1] ? static_cast<const APInt &>(-AElem)
-             : BElem.isZero()               ? APInt(AElem.getBitWidth(), 0)
-                                            : static_cast<const APInt &>(AElem);
+    return EvaluateBinOpExpr([](const APInt &AElem,
+                                const APInt &BElem) -> APInt {
+       if (BElem.isZero())
+            return APInt::getZero(AElem.getBitWidth());
+          if (BElem.isNegative())
+            return -AElem;
+          return AElem;
     });
 
   case X86::BI__builtin_ia32_blendvpd: