Fix MSVC warning C4127 "conditional expression is constant".

Author: StephanTLavavej

libcxx/test/std/algorithms/alg.modifying.operations/alg.rotate/rotate.pass.cpp

@@ -438,9 +438,8 @@ TEST_CONSTEXPR_CXX20 bool test_vector_bool() {
 TEST_CONSTEXPR_CXX20 bool test() {
   types::for_each(types::forward_iterator_list<int*>(), TestIter());
 
-#if TEST_STD_VER >= 11
-  if (TEST_STD_VER >= 23 || !TEST_IS_CONSTANT_EVALUATED)
-    types::for_each(types::forward_iterator_list<std::unique_ptr<int>*>(), TestUniquePtr());
+#if TEST_STD_VER >= 11 && TEST_STD_AT_LEAST_23_OR_RUNTIME_EVALUATED
+  types::for_each(types::forward_iterator_list<std::unique_ptr<int>*>(), TestUniquePtr());
 #endif
 
   test_vector_bool<8>();

libcxx/test/std/algorithms/alg.modifying.operations/alg.swap/swap_ranges.pass.cpp

@@ -142,10 +142,9 @@ TEST_CONSTEXPR_CXX20 bool test() {
 
   types::for_each(types::forward_iterator_list<int*>(), TestPtr());
 
-#if TEST_STD_VER >= 11
+#if TEST_STD_VER >= 11 && TEST_STD_AT_LEAST_23_OR_RUNTIME_EVALUATED
   // We can't test unique_ptr in constant evaluation before C++23 as it's constexpr only since C++23.
-  if (TEST_STD_VER >= 23 || !TEST_IS_CONSTANT_EVALUATED)
-    types::for_each(types::forward_iterator_list<std::unique_ptr<int>*>(), TestUniquePtr());
+  types::for_each(types::forward_iterator_list<std::unique_ptr<int>*>(), TestUniquePtr());
 #endif
 
   { // Test vector<bool>::iterator optimization

libcxx/test/std/utilities/utility/utility.swap/swap_array.pass.cpp

@@ -137,8 +137,9 @@ TEST_CONSTEXPR_CXX20 bool test() {
     static_assert(noexcept(std::swap(ma, ma)), "");
   }
 
-  if (TEST_STD_VER >= 23 || !TEST_IS_CONSTANT_EVALUATED)
-    test_unique_ptr();
+#  if TEST_STD_AT_LEAST_23_OR_RUNTIME_EVALUATED
+  test_unique_ptr();
+#  endif
 #endif
 
   return true;