Skip to content

Commit a6eddf9

Browse files
authored
[Loads] Pass DominatorTree if available (#95752)
For better dominance check inside the function.
1 parent eacc3b3 commit a6eddf9

File tree

2 files changed

+60
-1
lines changed

2 files changed

+60
-1
lines changed

llvm/lib/Analysis/Loads.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -165,7 +165,7 @@ static bool isDereferenceableAndAlignedPointer(
165165
if (getKnowledgeForValue(
166166
V, {Attribute::Dereferenceable, Attribute::Alignment}, AC,
167167
[&](RetainedKnowledge RK, Instruction *Assume, auto) {
168-
if (!isValidAssumeForContext(Assume, CtxI))
168+
if (!isValidAssumeForContext(Assume, CtxI, DT))
169169
return false;
170170
if (RK.AttrKind == Attribute::Alignment)
171171
AlignRK = std::max(AlignRK, RK);
Lines changed: 59 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,59 @@
1+
; NOTE: Assertions have been autogenerated by utils/update_test_checks.py
2+
; RUN: opt -passes=licm -S < %s | FileCheck %s
3+
4+
define void @f(i32 %ptr_i, ptr %ptr2, i1 %cond) {
5+
; CHECK-LABEL: @f(
6+
; CHECK-NEXT: entry:
7+
; CHECK-NEXT: [[PTR:%.*]] = inttoptr i32 [[PTR_I:%.*]] to ptr
8+
; CHECK-NEXT: call void @llvm.assume(i1 true) [ "align"(ptr [[PTR]], i32 16), "dereferenceable"(ptr [[PTR]], i32 16) ]
9+
; CHECK-NEXT: br i1 [[COND:%.*]], label [[FOR_BODY_LR_PH:%.*]], label [[IF0:%.*]]
10+
; CHECK: if0:
11+
; CHECK-NEXT: store i32 0, ptr [[PTR2:%.*]], align 4
12+
; CHECK-NEXT: br label [[FOR_BODY_LR_PH]]
13+
; CHECK: for.body.lr.ph:
14+
; CHECK-NEXT: [[TMP0:%.*]] = load i32, ptr [[PTR]], align 4
15+
; CHECK-NEXT: br label [[FOR_BODY:%.*]]
16+
; CHECK: for.body:
17+
; CHECK-NEXT: [[I_08:%.*]] = phi i32 [ 0, [[FOR_BODY_LR_PH]] ], [ [[INC:%.*]], [[IF_END:%.*]] ]
18+
; CHECK-NEXT: br i1 [[COND]], label [[IF_END]], label [[IF:%.*]]
19+
; CHECK: if:
20+
; CHECK-NEXT: store i32 [[TMP0]], ptr [[PTR2]], align 4
21+
; CHECK-NEXT: br label [[IF_END]]
22+
; CHECK: if.end:
23+
; CHECK-NEXT: [[INC]] = add nuw nsw i32 [[I_08]], 1
24+
; CHECK-NEXT: [[CMP:%.*]] = icmp slt i32 [[INC]], 2
25+
; CHECK-NEXT: br i1 [[CMP]], label [[FOR_BODY]], label [[EXIT:%.*]]
26+
; CHECK: exit:
27+
; CHECK-NEXT: ret void
28+
;
29+
entry:
30+
%ptr = inttoptr i32 %ptr_i to ptr
31+
call void @llvm.assume(i1 true) [ "align"(ptr %ptr, i32 16), "dereferenceable"(ptr %ptr, i32 16) ]
32+
br i1 %cond, label %for.body.lr.ph, label %if0
33+
34+
if0:
35+
store i32 0, ptr %ptr2, align 4
36+
br label %for.body.lr.ph
37+
38+
for.body.lr.ph: ; preds = %entry
39+
br label %for.body
40+
41+
for.body: ; preds = %for.body.lr.ph, %if.end
42+
%i.08 = phi i32 [ 0, %for.body.lr.ph ], [ %inc, %if.end ]
43+
br i1 %cond, label %if.end, label %if
44+
45+
if:
46+
%0 = load i32, ptr %ptr, align 4, !invariant.load !{}
47+
store i32 %0, ptr %ptr2, align 4
48+
br label %if.end
49+
50+
if.end: ; preds = %for.body
51+
%inc = add nuw nsw i32 %i.08, 1
52+
%cmp = icmp slt i32 %inc, 2
53+
br i1 %cmp, label %for.body, label %exit
54+
55+
exit: ; preds = %if.end, %entry
56+
ret void
57+
}
58+
59+
declare void @llvm.assume(i1 noundef)

0 commit comments

Comments
 (0)