qR3: Addressing a few review comments

Author: anchuraj

mlir/include/mlir/Dialect/OpenMP/OpenMPClauses.td

@@ -327,7 +327,7 @@ class OpenMP_ExclusiveClauseSkip<
 
   let extraClassDeclaration = [{
     bool hasExclusiveVars() {
-      return getExclusiveVars().size()>0;
+      return !getExclusiveVars().empty();
     }
   }];
 
@@ -337,6 +337,9 @@ class OpenMP_ExclusiveClauseSkip<
     is specified, the input phase excludes the preceding structured block 
     sequence and instead includes the following structured block sequence, 
     while the scan phase includes the preceding structured block sequence.
+
+    The `exclusive_vars` is a variadic list of operands that specifies the
+    scan-reduction accumulator symbols.
   }];
 }
 
@@ -471,7 +474,7 @@ class OpenMP_InclusiveClauseSkip<
 
   let extraClassDeclaration = [{
     bool hasInclusiveVars() {
-      return getInclusiveVars().size()>0;
+      return !getInclusiveVars().empty();
     }
   }];
 
@@ -480,6 +483,9 @@ class OpenMP_InclusiveClauseSkip<
     structured block into two structured block sequences. If it is specified,
     the input phase includes the preceding structured block sequence and the
     scan phase includes the following structured block sequence.
+
+    The `inclusive_vars` is a variadic list of operands that specifies the
+    scan-reduction accumulator symbols.
   }];
 }
 
@@ -548,7 +554,6 @@ class OpenMP_InReductionClauseSkip<
   ];
 
   let arguments = (ins
-    OptionalAttr<ReductionModifierAttr>:$in_reduction_mod,
     Variadic<OpenMP_PointerLikeType>:$in_reduction_vars,
     OptionalAttr<DenseBoolArrayAttr>:$in_reduction_byref,
     OptionalAttr<SymbolRefArrayAttr>:$in_reduction_syms
@@ -1208,7 +1213,6 @@ class OpenMP_TaskReductionClauseSkip<
   ];
 
   let arguments = (ins
-    OptionalAttr<ReductionModifierAttr>:$task_reduction_mod,
     Variadic<OpenMP_PointerLikeType>:$task_reduction_vars,
     OptionalAttr<DenseBoolArrayAttr>:$task_reduction_byref,
     OptionalAttr<SymbolRefArrayAttr>:$task_reduction_syms

mlir/include/mlir/Dialect/OpenMP/OpenMPEnums.td

@@ -195,7 +195,7 @@ def ReductionModifier : OpenMP_I32EnumAttr<
     ]>;
 
 def ReductionModifierAttr : OpenMP_EnumAttr<ReductionModifier,
-                                                  "reduction_modifier"> {
+                                            "reduction_modifier"> {
   let assemblyFormat = "`(` $value `)`";
 }
 

mlir/include/mlir/Dialect/OpenMP/OpenMPOps.td

@@ -461,7 +461,7 @@ def LoopOp : OpenMP_Op<"loop", traits = [
 
   let assemblyFormat = clausesAssemblyFormat # [{
     custom<PrivateReductionRegion>($region, $private_vars, type($private_vars),
-        $private_syms, $reduction_vars, type($reduction_vars), $reduction_byref,
+        $private_syms, $reduction_mod, $reduction_vars, type($reduction_vars), $reduction_byref,
         $reduction_syms) attr-dict
   }];
 
@@ -691,7 +691,7 @@ def TaskOp : OpenMP_Op<"task", traits = [
 
   let assemblyFormat = clausesAssemblyFormat # [{
     custom<InReductionPrivateRegion>(
-        $region, $in_reduction_mod, $in_reduction_vars, type($in_reduction_vars),
+        $region, $in_reduction_vars, type($in_reduction_vars),
         $in_reduction_byref, $in_reduction_syms, $private_vars,
         type($private_vars), $private_syms) attr-dict
   }];
@@ -769,7 +769,7 @@ def TaskloopOp : OpenMP_Op<"taskloop", traits = [
 
   let assemblyFormat = clausesAssemblyFormat # [{
     custom<InReductionPrivateReductionRegion>(
-        $region, $in_reduction_mod, $in_reduction_vars, type($in_reduction_vars),
+        $region, $in_reduction_vars, type($in_reduction_vars),
         $in_reduction_byref, $in_reduction_syms, $private_vars,
         type($private_vars), $private_syms, $reduction_mod, $reduction_vars,
         type($reduction_vars), $reduction_byref, $reduction_syms) attr-dict
@@ -816,7 +816,7 @@ def TaskgroupOp : OpenMP_Op<"taskgroup", traits = [
 
   let assemblyFormat = clausesAssemblyFormat # [{
     custom<TaskReductionRegion>(
-        $region, $task_reduction_mod, $task_reduction_vars, type($task_reduction_vars),
+        $region, $task_reduction_vars, type($task_reduction_vars),
         $task_reduction_byref, $task_reduction_syms) attr-dict
   }];
 
@@ -1237,7 +1237,7 @@ def TargetOp : OpenMP_Op<"target", traits = [
 
   let assemblyFormat = clausesAssemblyFormat # [{
     custom<InReductionMapPrivateRegion>(
-        $region, $in_reduction_mod, $in_reduction_vars, type($in_reduction_vars),
+        $region, $in_reduction_vars, type($in_reduction_vars),
         $in_reduction_byref, $in_reduction_syms, $map_vars, type($map_vars),
         $private_vars, type($private_vars), $private_syms) attr-dict
   }];
@@ -1653,15 +1653,15 @@ def CancellationPointOp : OpenMP_Op<"cancellation_point", clauses = [
 }
 
 def ScanOp : OpenMP_Op<"scan", [
-    AttrSizedOperandSegments, RecipeInterface, IsolatedFromAbove
+    AttrSizedOperandSegments
   ], clauses = [
-  OpenMP_InclusiveClause, OpenMP_ExclusiveClause]> {
+    OpenMP_InclusiveClause, OpenMP_ExclusiveClause]> {
   let summary = "scan directive";
   let description = [{
-    The scan directive allows to specify scan reduction. Scan directive
-    should be enclosed with in a parent directive along with which, a
-    reduction clause with `InScan` modifier must be specified. Scan directive
-    allows to separate code blocks to input phase and scan phase in the region
+    The scan directive allows to specify scan reductions. It should be
+    enclosed within a parent directive along with which a reduction clause
+    with `inscan` modifier must be specified. The scan directive allows to
+    split code blocks into input phase and scan phase in the region
     enclosed by the parent.
   }] # clausesDescription;