Removed the redundant OCE->getNumArgs() == 2 check in VisitCXXOperatorCallExpr when it's an assignment,

and added tests for ternary expresssion per review comments.

Author: rniwa

clang/lib/StaticAnalyzer/Checkers/WebKit/UncountedLocalVarsChecker.cpp

@@ -95,7 +95,8 @@ struct GuardianVisitor : public RecursiveASTVisitor<GuardianVisitor> {
   }
 
   bool VisitCXXOperatorCallExpr(const CXXOperatorCallExpr *OCE) {
-    if (OCE->isAssignmentOp() && OCE->getNumArgs() == 2) {
+    if (OCE->isAssignmentOp()) {
+      assert(OCE->getNumArgs() == 2);
       auto *ThisArg = OCE->getArg(0)->IgnoreParenCasts();
       if (auto *VarRef = dyn_cast<DeclRefExpr>(ThisArg)) {
         if (VarRef->getDecl() == Guardian)

clang/test/Analysis/Checkers/WebKit/uncounted-local-vars.cpp

@@ -111,6 +111,12 @@ void foo8(RefCountable* obj) {
     foo.releaseNonNull();
     bar->method();
   }
+  {
+    RefCountable *bar = foo.get();
+    // expected-warning@-1{{Local variable 'bar' is uncounted and unsafe [alpha.webkit.UncountedLocalVarsChecker]}}
+    foo = obj ? obj : nullptr;
+    bar->method();
+  }
 }
 
 void foo9(RefCountable& o) {
@@ -140,6 +146,12 @@ void foo9(RefCountable& o) {
     guardian.leakRef();
     bar->method();
   }
+  {
+    RefCountable *bar = guardian.ptr();
+    // expected-warning@-1{{Local variable 'bar' is uncounted and unsafe [alpha.webkit.UncountedLocalVarsChecker]}}
+    guardian = o.trivial() ? o : *bar;
+    bar->method();
+  }
 }
 
 } // namespace guardian_scopes