review comment address

Author: javedabsar1

mlir/test/Dialect/Linalg/elementwise/named-to-elementwise.mlir

@@ -26,15 +26,15 @@ func.func @add(%A : tensor<16x8xf32>, %B: tensor<16x8xf32>, %C : tensor<16x8xf32
 
 // ----
 
-// CHECK: @sub(%[[A:.+]]: memref<16x8xf32>, %[[B:.+]]: memref<16x8xf32>, %[[C:.+]]: memref<16x8xf32>) {
-// CHECK:      linalg.elementwise
+// CHECK: @sub(%[[A:.+]]: tensor<16x8xf32>, %[[B:.+]]: tensor<16x8xf32>, %[[C:.+]]: tensor<16x8xf32>) -> tensor<16x8xf32> {
+// CHECK: {{.*}} = linalg.elementwise
 // CHECK-SAME:       kind=#linalg.elementwise_kind<sub>
-// CHECK-SAME:       ins(%[[A]], %[[B]] : memref<16x8xf32>, memref<16x8xf32>)
-// CHECK-SAME:       outs(%[[C]] : memref<16x8xf32>)
+// CHECK-SAME:       ins(%[[A]], %[[B]] : tensor<16x8xf32>, tensor<16x8xf32>)
+// CHECK-SAME:       outs(%[[C]] : tensor<16x8xf32>)
 //
-func.func @sub(%A : memref<16x8xf32>, %B: memref<16x8xf32>, %C : memref<16x8xf32>) {
-  linalg.sub ins(%A, %B : memref<16x8xf32>, memref<16x8xf32>) outs(%C :  memref<16x8xf32>)
-  return
+func.func @sub(%A : tensor<16x8xf32>, %B: tensor<16x8xf32>, %C : tensor<16x8xf32>) -> tensor<16x8xf32> {
+  %sub = linalg.sub ins(%A, %B : tensor<16x8xf32>, tensor<16x8xf32>) outs(%C :  tensor<16x8xf32>) -> tensor<16x8xf32>
+  return %sub : tensor<16x8xf32>
 }
 
 // ----

mlir/test/Dialect/Linalg/linalg-morph-multi-step.mlir

@@ -1,6 +1,6 @@
 // RUN: mlir-opt %s -linalg-morph-ops=named-to-generic |  FileCheck %s  --check-prefix=NAMED_TO_GENERIC
 // RUN: mlir-opt %s -linalg-morph-ops=named-to-generic |  mlir-opt %s -linalg-morph-ops=generic-to-named | \
-// RUN:   FileCheck %s  --check-prefix=GENERIC_TO_NAMED
+// RUN:   FileCheck %s  --check-prefix=ROUND_TRIP
 
 func.func @exp(%A : tensor<16x8xf32>, %B : tensor<16x8xf32>) ->  tensor<16x8xf32> {
   %exp = linalg.exp ins(%A : tensor<16x8xf32>) outs(%B :  tensor<16x8xf32>) -> tensor<16x8xf32>
@@ -10,5 +10,5 @@ func.func @exp(%A : tensor<16x8xf32>, %B : tensor<16x8xf32>) ->  tensor<16x8xf32
 // NAMED_TO_GENERIC: linalg.generic
 // NAMED_TO_GENERIC-NOT: linalg.exp
 
-// GENERIC_TO_NAMED: linalg.exp
-// GENERIC_TO_NAMED-NOT: linalg.generic
+// ROUND_TRIP: linalg.exp
+// ROUND_TRIP-NOT: linalg.generic