Skip to content

Commit aa5bb01

Browse files
Adopt @ashgti‘s review comments
- Change the default argument for `disableASLR` in `dap_server.py`. - Revert change in `TestDAP_subtleFrames.py`.
1 parent 5012767 commit aa5bb01

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

lldb/packages/Python/lldbsuite/test/tools/lldb-dap/dap_server.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -856,7 +856,7 @@ def request_launch(
856856
cwd: Optional[str] = None,
857857
env: Optional[dict[str, str]] = None,
858858
stopOnEntry=False,
859-
disableASLR=True,
859+
disableASLR=False,
860860
disableSTDIO=False,
861861
shellExpandArguments=False,
862862
runInTerminal=False,

lldb/test/API/tools/lldb-dap/stackTrace/subtleFrames/TestDAP_subtleFrames.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ def test_subtleFrames(self):
1717
Internal stack frames (such as the ones used by `std::function`) are marked as "subtle".
1818
"""
1919
program = self.getBuildArtifact("a.out")
20-
self.build_and_launch(program, disableASLR=False)
20+
self.build_and_launch(program)
2121
source = "main.cpp"
2222
self.set_source_breakpoints(source, [line_number(source, "BREAK HERE")])
2323
self.continue_to_next_stop()

0 commit comments

Comments
 (0)