Skip to content

Commit ab82e4c

Browse files
committed
address pr comments
1 parent d33fd57 commit ab82e4c

File tree

1 file changed

+2
-3
lines changed

1 file changed

+2
-3
lines changed

llvm/lib/Target/DirectX/DXILDataScalarization.cpp

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,6 @@ class DataScalarizerVisitor : public InstVisitor<DataScalarizerVisitor, bool> {
6767
private:
6868
GlobalVariable *lookupReplacementGlobal(Value *CurrOperand);
6969
DenseMap<GlobalVariable *, GlobalVariable *> GlobalMap;
70-
static bool isArrayOfVectors(Type *T);
7170
};
7271

7372
bool DataScalarizerVisitor::visit(Function &F) {
@@ -91,7 +90,7 @@ DataScalarizerVisitor::lookupReplacementGlobal(Value *CurrOperand) {
9190
return nullptr; // Not found
9291
}
9392

94-
// Recursively Creates and Array like version of the given vector like type.
93+
// Recursively creates an array version of the given vector type.
9594
static Type *replaceVectorWithArray(Type *T, LLVMContext &Ctx) {
9695
if (auto *VecTy = dyn_cast<VectorType>(T))
9796
return ArrayType::get(VecTy->getElementType(),
@@ -105,7 +104,7 @@ static Type *replaceVectorWithArray(Type *T, LLVMContext &Ctx) {
105104
return T;
106105
}
107106

108-
bool DataScalarizerVisitor::isArrayOfVectors(Type *T) {
107+
static bool isArrayOfVectors(Type *T) {
109108
if (ArrayType *ArrType = dyn_cast<ArrayType>(T))
110109
return isa<VectorType>(ArrType->getElementType());
111110
return false;

0 commit comments

Comments
 (0)