Skip to content

Commit ab88038

Browse files
committed
better?
1 parent 8496a1b commit ab88038

File tree

1 file changed

+6
-12
lines changed
  • .github/workflows/containers/github-action-ci-tooling

1 file changed

+6
-12
lines changed

.github/workflows/containers/github-action-ci-tooling/Dockerfile

Lines changed: 6 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -3,16 +3,16 @@ FROM docker.io/library/ubuntu:24.04 AS llvm-downloader
33
ENV LLVM_VERSION=21.1.2
44

55
RUN apt-get update && \
6-
apt-get install -y wget pixz && \
6+
apt-get install -y wget xz-utils && \
77
wget --progress=bar:force -O llvm.tar.xz https://github.com/llvm/llvm-project/releases/download/llvmorg-${LLVM_VERSION}/LLVM-${LLVM_VERSION}-Linux-X64.tar.xz && \
88
mkdir -p /llvm-extract && \
9-
pixz -d llvm.tar.xz && \
10-
tar -xvf llvm.tar -C /llvm-extract LLVM-${LLVM_VERSION}-Linux-X64/bin/ && \
11-
rm llvm.tar
9+
tar -xvJf llvm.tar.xz -C /llvm-extract LLVM-${LLVM_VERSION}-Linux-X64/bin/ && \
10+
rm llvm.tar.xz
1211

1312
FROM docker.io/library/ubuntu:24.04 AS base
1413

1514
ENV LLVM_SYSROOT=/opt/llvm
15+
ENV LLVM_VERSION=21.1.2
1616

1717
# Need nodejs for some of the GitHub actions.
1818
# Need git for git-clang-format.
@@ -21,10 +21,8 @@ RUN apt-get update && \
2121
git \
2222
nodejs \
2323
sudo \
24-
# These are needed by the premerge pipeline. Pip and venv are used to
25-
# install dependent python packages.
26-
# Having a symlink from python to python3 enables code sharing between
27-
# the Linux and Windows pipelines.
24+
# These are needed by the premerge pipeline.
25+
# Pip and venv are used to install dependent python packages.
2826
python3-pip \
2927
python3-venv \
3028
python-is-python3 && \
@@ -47,8 +45,6 @@ WORKDIR /home/gha
4745

4846
FROM base AS ci-container-code-format
4947

50-
ENV LLVM_VERSION=21.1.2
51-
5248
COPY --from=llvm-downloader /llvm-extract/LLVM-${LLVM_VERSION}-Linux-X64/bin/clang-format ${LLVM_SYSROOT}/bin/clang-format
5349

5450
ENV PATH=${LLVM_SYSROOT}/bin:${PATH}
@@ -62,8 +58,6 @@ RUN python -m venv venv && \
6258
# Stage 4: clang-lint container
6359
FROM base AS ci-container-code-lint
6460

65-
ENV LLVM_VERSION=21.1.2
66-
6761
COPY --from=llvm-downloader /llvm-extract/LLVM-${LLVM_VERSION}-Linux-X64/bin/clang-tidy ${LLVM_SYSROOT}/bin/
6862
COPY clang-tools-extra/clang-tidy/tool/clang-tidy-diff.py ${LLVM_SYSROOT}/bin/clang-tidy-diff.py
6963

0 commit comments

Comments
 (0)