Templatize existing tests

Author: frederick-vs-ja

libcxx/test/std/containers/sequences/vector.bool/vector_bool.pass.cpp

@@ -22,9 +22,10 @@
 #include "test_macros.h"
 #include "min_allocator.h"
 
-TEST_CONSTEXPR_CXX20 bool tests() {
+template <class VB>
+TEST_CONSTEXPR_CXX20 void test() {
   {
-    typedef std::vector<bool> T;
+    typedef VB T;
     typedef std::hash<T> H;
 #if TEST_STD_VER <= 14
     static_assert((std::is_same<H::argument_type, T>::value), "");
@@ -36,25 +37,17 @@ TEST_CONSTEXPR_CXX20 bool tests() {
     T vb(std::begin(ba), std::end(ba));
     H h;
     if (!TEST_IS_CONSTANT_EVALUATED) {
-      assert(h(vb) == h(vb));
+      const std::size_t hash_value = h(vb);
+      assert(h(vb) == hash_value);
+      LIBCPP_ASSERT(hash_value != 0);
     }
   }
+}
+
+TEST_CONSTEXPR_CXX20 bool tests() {
+  test<std::vector<bool> >();
 #if TEST_STD_VER >= 11
-  {
-    typedef std::vector<bool, min_allocator<bool>> T;
-    typedef std::hash<T> H;
-#  if TEST_STD_VER <= 14
-    static_assert((std::is_same<H::argument_type, T>::value), "");
-    static_assert((std::is_same<H::result_type, std::size_t>::value), "");
-#  endif
-    ASSERT_NOEXCEPT(H()(T()));
-    bool ba[] = {true, false, true, true, false};
-    T vb(std::begin(ba), std::end(ba));
-    H h;
-    if (!TEST_IS_CONSTANT_EVALUATED) {
-      assert(h(vb) == h(vb));
-    }
-  }
+  test<std::vector<bool, min_allocator<bool>>>();
 #endif
 
   return true;