Skip to content

Commit abc84c7

Browse files
committed
add offsets to load
1 parent 59f7ea9 commit abc84c7

File tree

2 files changed

+17
-3
lines changed

2 files changed

+17
-3
lines changed

mlir/include/mlir/Dialect/XeGPU/IR/XeGPUOps.td

Lines changed: 16 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -699,6 +699,8 @@ def XeGPU_LoadGatherOp : XeGPU_Op<"load", [
699699
}];
700700

701701
let arguments = (ins XeGPU_TensorDesc_or_MemRef: $source,
702+
Variadic<Index>: $offsets,
703+
OptionalAttr<DenseI64ArrayAttr>: $const_offsets,
702704
XeGPU_MaskType: $mask,
703705
OptionalAttr<XeGPU_CacheHintAttr>: $l1_hint,
704706
OptionalAttr<XeGPU_CacheHintAttr>: $l2_hint,
@@ -730,8 +732,20 @@ def XeGPU_LoadGatherOp : XeGPU_Op<"load", [
730732

731733
}];
732734

733-
let assemblyFormat = [{$source `,` $mask prop-dict attr-dict
734-
`:` qualified(type($source)) `,` type($mask) `->` type($value)}];
735+
let assemblyFormat = [{
736+
$source `,`
737+
custom<OptionalDynamicIndexList>($offsets, $const_offsets)
738+
$mask prop-dict
739+
attr-dict `:` qualified(type($source)) `,` type($mask) `->` type($value)
740+
}];
741+
742+
// let builders = [
743+
// OpBuilder<(ins "Type": $value, "Value": $TensorDesc,
744+
// "UnitAttr": $packed, "DenseI64ArrayAttr": $transpose,
745+
// "xegpu::CachePolicyAttr": $l1_hint,
746+
// "xegpu::CachePolicyAttr": $l2_hint,
747+
// "xegpu::CachePolicyAttr": $l3_hint)>
748+
// ];
735749

736750
let hasVerifier = 1;
737751
}

mlir/include/mlir/Dialect/XeGPU/IR/XeGPUTypes.td

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -189,7 +189,7 @@ def XeGPU_TensorDesc: XeGPUTypeDef<"TensorDesc", "tensor_desc",
189189
let genVerifyDecl = 1;
190190
}
191191

192-
def XeGPU_TensorDesc_or_MemRef : AnyTypeOf<[XeGPU_TensorDesc,Non0RankedMemRefOf<[XeGPU_ScalarType]>]>;
192+
def XeGPU_TensorDesc_or_MemRef : AnyTypeOf<[XeGPU_TensorDesc,Non0RankedMemRefOf<[XeGPU_ScalarType]>, UI64]>;
193193

194194
def XeGPU_Nbarrier: XeGPUTypeDef<"Nbarrier", "nbarrier", [], "mlir::Type"> {
195195
let summary = "!xegpu.nbarrier a custom XeGPU type representing a barrier.";

0 commit comments

Comments
 (0)