ix the index constraint to accept -1 as valid index

AmrDeveloper · AmrDeveloper · commit abe1bc9442a1 · 2025-06-08T12:27:20.000+02:00
diff --git a/clang/lib/CIR/Dialect/IR/CIRDialect.cpp b/clang/lib/CIR/Dialect/IR/CIRDialect.cpp
@@ -1602,7 +1602,7 @@ LogicalResult cir::VecShuffleOp::verify() {
   const uint64_t maxValidIndex =
       getVec1().getType().getSize() + getVec2().getType().getSize() - 1;
   for (const auto &idxAttr : getIndices().getAsRange<cir::IntAttr>()) {
-    if (idxAttr.getUInt() > maxValidIndex)
+    if (idxAttr.getSInt() != -1 && idxAttr.getUInt() > maxValidIndex)
       return emitOpError() << ": index for __builtin_shufflevector must be "
                               "less than the total number of vector elements";
   }

Original file line number	Diff line number	Diff line change
`@@ -1602,7 +1602,7 @@ LogicalResult cir::VecShuffleOp::verify() {`
`1602`	`1602`	`const uint64_t maxValidIndex =`
`1603`	`1603`	`getVec1().getType().getSize() + getVec2().getType().getSize() - 1;`
`1604`	`1604`	`for (const auto &idxAttr : getIndices().getAsRange<cir::IntAttr>()) {`
`1605`		`- if (idxAttr.getUInt() > maxValidIndex)`
	`1605`	`+ if (idxAttr.getSInt() != -1 && idxAttr.getUInt() > maxValidIndex)`
`1606`	`1606`	`return emitOpError() << ": index for __builtin_shufflevector must be "`
`1607`	`1607`	`"less than the total number of vector elements";`
`1608`	`1608`	`}`