[Analysis] Avoid repeated hash lookups (NFC) (#107357)

kazutakahirata · web-flow · commit abfb340b779f · 2024-09-05T08:35:46.000-07:00
diff --git a/clang/lib/Analysis/ThreadSafety.cpp b/clang/lib/Analysis/ThreadSafety.cpp
@@ -1180,8 +1180,7 @@ void BeforeSet::checkBeforeAfter(const ValueDecl* StartVd,
       }
       // Transitively search other before sets, and warn on cycles.
       if (traverse(Vdb)) {
-        if (!CycMap.contains(Vd)) {
-          CycMap.insert(std::make_pair(Vd, true));
+        if (CycMap.try_emplace(Vd, true).second) {
           StringRef L1 = Vd->getName();
           Analyzer.Handler.handleBeforeAfterCycle(L1, Vd->getLocation());
         }

Original file line number	Diff line number	Diff line change
`@@ -1180,8 +1180,7 @@ void BeforeSet::checkBeforeAfter(const ValueDecl* StartVd,`
`1180`	`1180`	`}`
`1181`	`1181`	`// Transitively search other before sets, and warn on cycles.`
`1182`	`1182`	`if (traverse(Vdb)) {`
`1183`		`- if (!CycMap.contains(Vd)) {`
`1184`		`- CycMap.insert(std::make_pair(Vd, true));`
	`1183`	`+ if (CycMap.try_emplace(Vd, true).second) {`
`1185`	`1184`	`StringRef L1 = Vd->getName();`
`1186`	`1185`	`Analyzer.Handler.handleBeforeAfterCycle(L1, Vd->getLocation());`
`1187`	`1186`	`}`