Apply style nits from review

Co-authored-by: Tobias Gysi <[email protected]>

Author: krzysz00

mlir/lib/Target/LLVMIR/Dialect/LLVMIR/LLVMIRToLLVMTranslation.cpp

@@ -215,25 +215,24 @@ static LogicalResult setDereferenceableAttr(const llvm::MDNode *node,
   return success();
 }
 
-/// Convert the given MMRA metadata (either an MMRA tag or an array of rhem)
+/// Convert the given MMRA metadata (either an MMRA tag or an array of them)
 /// into corresponding MLIR attributes and set them on the given operation as a
 /// discardable `llvm.mmra` attribute.
 static LogicalResult setMmraAttr(llvm::MDNode *node, Operation *op,
                                  LLVM::ModuleImport &moduleImport) {
   llvm::MMRAMetadata wrapper(node);
-  if (wrapper.empty()) {
+  if (wrapper.empty()) 
     return success();
-  }
+ 
   MLIRContext *ctx = op->getContext();
   Attribute mlirMmra;
   if (wrapper.size() == 1) {
     auto [prefix, suffix] = *wrapper.begin();
     mlirMmra = LLVM::MMRATagAttr::get(ctx, prefix, suffix);
   } else {
     SmallVector<Attribute> tags;
-    for (auto [prefix, suffix] : wrapper) {
+    for (auto [prefix, suffix] : wrapper) 
       tags.push_back(LLVM::MMRATagAttr::get(ctx, prefix, suffix));
-    }
     mlirMmra = ArrayAttr::get(ctx, tags);
   }
   op->setAttr(LLVMDialect::getMmraAttrName(), mlirMmra);

mlir/lib/Target/LLVMIR/Dialect/LLVMIR/LLVMToLLVMIRTranslation.cpp

@@ -735,7 +735,7 @@ amendOperationImpl(Operation &op, ArrayRef<llvm::Instruction *> instructions,
     if (auto oneTag = dyn_cast<LLVM::MMRATagAttr>(attribute.getValue())) {
       tags.emplace_back(oneTag.getPrefix(), oneTag.getSuffix());
     } else if (auto manyTags = dyn_cast<ArrayAttr>(attribute.getValue())) {
-      for (auto a : manyTags) {
+      for (Attribute attr : manyTags) {
         auto tag = dyn_cast<MMRATagAttr>(a);
         if (tag) {
           tags.emplace_back(tag.getPrefix(), tag.getSuffix());
@@ -754,9 +754,8 @@ amendOperationImpl(Operation &op, ArrayRef<llvm::Instruction *> instructions,
       // Empty list, canonicalizes to nothing
       return success();
     }
-    for (llvm::Instruction *inst : instructions) {
+    for (llvm::Instruction *inst : instructions) 
       inst->setMetadata(llvm::LLVMContext::MD_mmra, mmraMd);
-    }
     return success();
   }
   return success();